Re: [PATCH 04/10] mm: slub: add knowledge of reserve pages

Daniel Phillips
2007-08-10T01:54:01Z

On 8/8/07, Andrew Morton <akpm@linux-foundation.org> wrote:
> On Wed, 8 Aug 2007 10:57:13 -0700 (PDT)
> Christoph Lameter <clameter@sgi.com> wrote:
>
> > I think in general irq context reclaim is doable. Cannot see obvious
> > issues on a first superficial pass through rmap.c. The irq holdoff would
> > be pretty long though which may make it unacceptable.
>
> The IRQ holdoff could be tremendous. But if it is sufficiently infrequent
> and if the worst effect is merely a network rx ring overflow then the tradeoff
> might be a good one.

Hi Andrew,

No matter how you look at this problem, you still need to have _some_
sort of reserve, and limit access to it. We extend existing methods,
you are proposing to what seems like an entirely new reserve
management system. Great idea, maybe, but it does not solve the
deadlocks. You still need some organized way of being sure that your
reserve is as big as you need (hopefully not an awful lot bigger) and
you still have to make sure that nobody dips into that reserve further
than they are allowed to.

So translation: reclaim from "easily freeable" lists is an
optimization, maybe a great one. Probably great. Reclaim from atomic
context is also a great idea, probably. But you are talking about a
whole nuther patch set. Neither of those are in themselves a fix for
these deadlocks.

Regards,

Daniel