Re: [PATCH 03/10] mm: tag reseve pages

Peter Zijlstra
2007-08-06T18:47:59Z

On Mon, 2007-08-06 at 11:43 -0700, Christoph Lameter wrote:
> On Mon, 6 Aug 2007, Andi Kleen wrote:
>
> > > > pgoff_t index; /* Our offset within mapping. */
> > > > void *freelist; /* SLUB: freelist req. slab lock */
> > > > + int reserve; /* page_alloc: page is a reserve page */
> > >
> > > Extending page struct ???
> >
> > Note it's an union.
>
> Ok. Then under what conditions can we use reserve? Right after alloc?

Yes, its usually only observed right after alloc. Its basically an extra
return value.

Daniel suggested it was about saving page flags, _maybe_. The value is
1) rare and 2) usually only interesting right after alloc. So wasting a
precious page flag which would keep this state for the duration of the
whole allocation seemed like a waste.