Re: [PATCH 9/9] pagemap: export swap ptes

Matt Mackall
2007-08-24T16:56:16Z

On Fri, Aug 24, 2007 at 09:19:22AM -0700, Dave Hansen wrote:
> On Thu, 2007-08-23 at 19:29 -0500, Matt Mackall wrote:
> > On Wed, Aug 22, 2007 at 04:18:14PM -0700, Dave Hansen wrote:
> > >
> > > In addition to understanding which physical pages are
> > > used by a process, it would also be very nice to
> > > enumerate how much swap space a process is using.
> > >
> > > This patch enables /proc/<pid>/pagemap to display
> > > swap ptes. In the process, it also changes the
> > > constant that we used to indicate non-present ptes
> > > before.
> > >
> > > Signed-off-by: Dave Hansen <haveblue@us.ibm.com>
> >
> > I suspect you missed a quilt add here, as is_swap_pte is not in any
> > header file and is thus implicitly declared.
>
> Yeah, I have another patch that was declared waaaaaaay earlier in my
> series that does this.

I moved it from mm/migrate.c to include/linux/swapops.h here.

> I'm not completely confident in the way that I
> formatted the swap pte, so let's hold off on just this patch for now.
> I'll rework it and send it your way again in a few days.

Yeah, that bit is a little tricky. I'm going to be off the net for the
next week or so, so I can pick this up in September. I should just
need a resend of this patch.

--
Mathematics is the supreme nostalgia of our time.