Re: [PATCH 4/4] add SGI Altix cross partition memory (XPMEM) driver

Robin Holt
2007-08-28T19:00:43Z

On Tue, Aug 28, 2007 at 07:02:35PM +0100, Christoph Hellwig wrote:
> Big fat NACK, for dirty VM tricks, playing with task_struct lifetimes,
> and last but not least the horrible ioctl "API".

The ioctl is sort of historical. IIRC, in ProPack 3 (RHEL4 based 2.4
kernel), we added system calls. When the community started making noise
about system calls being bad, we went to a device special file with a
read/write (couldn't get the needed performance from the ioctl() interface
which used to acquire the BKL). Now that the community fixed the ioctl
issues, we went to using an ioctl, but are completely open to change.

If you want to introduce system calls, we would expect to need, IIRC, 8.
We also pondered an xpmem filesystem today. It really felt wrong,
but we could pursue that as an alternative.

What is the correct direction to go with this? get_user_pages() does
currently require the task_struct. Are you proposing we develop a way
to fault pages without the task_struct of the owning process/thread group?

Thanks,
Robin