From: Fengguang Wu <wfg@mail.ustc.edu.cn>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: John Berthels <jjberthels@gmail.com>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
Denys Vlasenko <vda.linux@googlemail.com>,
Matt Mackall <mpm@selenic.com>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [PATCH][RESEND] maps: PSS(proportional set size) accounting in smaps
Date: Mon, 17 Sep 2007 15:21:36 +0800 [thread overview]
Message-ID: <390013699.27169@ustc.edu.cn> (raw)
Message-ID: <20070917072136.GA5706@mail.ustc.edu.cn> (raw)
In-Reply-To: <20070916235120.713c6102.akpm@linux-foundation.org>
On Sun, Sep 16, 2007 at 11:51:20PM -0700, Andrew Morton wrote:
> On Mon, 17 Sep 2007 10:40:54 +0800 Fengguang Wu <wfg@mail.ustc.edu.cn> wrote:
>
> > Matt Mackall's pagemap/kpagemap and John Berthels's exmap can also do the job.
> > They are comprehensive tools. But for PSS, let's do it in the simple way.
>
> right. I'm rather reluctant to merge anything which could have been done from
> userspace via the maps2 interfaces.
Agreed. My thought was that PSS will be used far more widely than
other maps2 memory analysis tools. Providing PSS in smaps could
possibly help simplify many ps/top like tools.
> See, this is why I think the kernel needs a ./userspace-tools/ directory. If
> we had that, you might have implemented this as a little proglet which parses
> the maps2 files. But we don't have that, so you ended up doing it in-kernel.
Because Matt didn't put it there ;-)
I wholly agree that it is a good practice to carry some user space
tools with the kernel as the reference implementations. We already
have some in the Document/ and usr/ directories.
Fengguang
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-09-17 7:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070917024054.GA12036@mail.ustc.edu.cn>
2007-09-17 2:40 ` [PATCH][RESEND] maps: PSS(proportional set size) accounting in smaps Fengguang Wu
2007-09-17 6:51 ` Andrew Morton
2007-09-17 7:08 ` Userspace tools (was Re: [PATCH][RESEND] maps: PSS(proportional set size) accounting in smaps) Balbir Singh
2007-09-17 9:00 ` Christoph Hellwig
2007-09-17 9:11 ` Balbir Singh
2007-09-17 9:15 ` Christoph Hellwig
2007-09-17 12:29 ` Userspace tools Karel Zak
2007-09-17 9:13 ` Userspace tools (was Re: [PATCH][RESEND] maps: PSS(proportional set size) accounting in smaps) Andrew Morton
[not found] ` <20070917072136.GA5706@mail.ustc.edu.cn>
2007-09-17 7:21 ` Fengguang Wu [this message]
2007-09-17 16:10 ` [PATCH][RESEND] maps: PSS(proportional set size) accounting in smaps Matt Mackall
2007-09-17 17:49 ` Denys Vlasenko
2007-09-19 8:37 ` John Berthels
[not found] ` <20070919085625.GA5910@mail.ustc.edu.cn>
2007-09-19 8:56 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=390013699.27169@ustc.edu.cn \
--to=wfg@mail.ustc.edu.cn \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=jjberthels@gmail.com \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=vda.linux@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).