linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Chinner <dgc@sgi.com>
To: Fengguang Wu <wfg@mail.ustc.edu.cn>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Miklos Szeredi <miklos@szeredi.hu>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remove throttle_vm_writeout()
Date: Mon, 8 Oct 2007 09:54:33 +1000	[thread overview]
Message-ID: <20071007235433.GW995458@sgi.com> (raw)
In-Reply-To: <20071005123028.GA10372@mail.ustc.edu.cn>

On Fri, Oct 05, 2007 at 08:30:28PM +0800, Fengguang Wu wrote:
> The improvement could be:
> - kswapd is now explicitly preferred to do the writeout;

Careful. kswapd is much less efficient at writeout than pdflush
because it does not do low->high offset writeback per address space.
It just flushes the pages in LRU order and that turns writeback into
a non-sequential mess. I/O sizes decrease substantially and
throughput falls through the floor.

So if you want kswapd to take over all the writeback, it needs to do
writeback in the same manner as the background flushes. i.e.  by
grabbing page->mapping and flushing that in sequential order rather
than just the page on the end of the LRU....

I documented the effect of kswapd taking over writeback in this
paper (section 5.3):

http://oss.sgi.com/projects/xfs/papers/ols2006/ols-2006-paper.pdf

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2007-10-07 23:54 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-04 12:25 [PATCH] remove throttle_vm_writeout() Miklos Szeredi
2007-10-04 12:40 ` Peter Zijlstra
2007-10-04 13:00   ` Miklos Szeredi
2007-10-04 13:23     ` Peter Zijlstra
2007-10-04 13:49       ` Miklos Szeredi
2007-10-04 16:47         ` Peter Zijlstra
2007-10-04 17:46           ` Andrew Morton
2007-10-04 18:10             ` Peter Zijlstra
2007-10-04 18:54               ` Andrew Morton
     [not found]             ` <20071005123028.GA10372@mail.ustc.edu.cn>
2007-10-05 12:30               ` Fengguang Wu
2007-10-05 17:20                 ` Andrew Morton
     [not found]                   ` <20071006023224.GA7526@mail.ustc.edu.cn>
2007-10-06  2:32                     ` Fengguang Wu
2007-10-07 23:54               ` David Chinner [this message]
     [not found]                 ` <20071008003349.GA5455@mail.ustc.edu.cn>
2007-10-08  0:33                   ` Fengguang Wu
2007-10-04 21:07           ` Miklos Szeredi
2007-10-04 21:56 ` Andrew Morton
2007-10-04 22:39   ` Miklos Szeredi
2007-10-04 23:09     ` Andrew Morton
2007-10-04 23:26       ` Miklos Szeredi
2007-10-04 23:48         ` Andrew Morton
2007-10-05  0:12           ` Miklos Szeredi
2007-10-05  0:48             ` Andrew Morton
2007-10-05  8:22               ` Peter Zijlstra
2007-10-05  9:22                 ` Miklos Szeredi
2007-10-05  9:47                   ` Peter Zijlstra
2007-10-05 10:27                     ` Miklos Szeredi
2007-10-05 10:32                       ` Miklos Szeredi
2007-10-05 15:43                         ` John Stoffel
2007-10-05 10:57                       ` Peter Zijlstra
2007-10-05 11:27                         ` Miklos Szeredi
2007-10-05 17:50                         ` Trond Myklebust
2007-10-05 18:32                           ` Peter Zijlstra
2007-10-05 19:20                             ` Trond Myklebust
2007-10-05 19:23                               ` Trond Myklebust
2007-10-05 21:07                                 ` Peter Zijlstra
     [not found]                             ` <20071006004028.GA7121@mail.ustc.edu.cn>
2007-10-06  0:40                               ` Fengguang Wu
2007-10-05  7:32       ` Peter Zijlstra
2007-10-05 19:54         ` Rik van Riel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071007235433.GW995458@sgi.com \
    --to=dgc@sgi.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=miklos@szeredi.hu \
    --cc=wfg@mail.ustc.edu.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).