* [PATCH 0/1] x86: convert-cpuinfo_x86-array-to-a-per_cpu-array fix
@ 2007-10-12 22:54 travis
2007-10-12 22:54 ` [PATCH 1/1] " travis
0 siblings, 1 reply; 5+ messages in thread
From: travis @ 2007-10-12 22:54 UTC (permalink / raw)
To: Andrew Morton, Suresh B Siddha; +Cc: Christoph Lameter, linux-kernel, linux-mm
This fix corrects the problem that early_identify_cpu() sets
cpu_index to '0' (needed when called by setup_arch) after
smp_store_cpu_info() had set it to the correct value.
Thanks to Suresh for discovering this problem.
--
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/1] x86: convert-cpuinfo_x86-array-to-a-per_cpu-array fix
2007-10-12 22:54 [PATCH 0/1] x86: convert-cpuinfo_x86-array-to-a-per_cpu-array fix travis
@ 2007-10-12 22:54 ` travis
2007-10-23 5:36 ` Yinghai Lu
2007-11-14 18:45 ` Mike Travis
0 siblings, 2 replies; 5+ messages in thread
From: travis @ 2007-10-12 22:54 UTC (permalink / raw)
To: Andrew Morton, Suresh B Siddha; +Cc: Christoph Lameter, linux-kernel, linux-mm
[-- Attachment #1: x86-convert-cpuinfo_x86-array-to-a-per_cpu-array-fix --]
[-- Type: text/plain, Size: 909 bytes --]
This fix corrects the problem that early_identify_cpu() sets
cpu_index to '0' (needed when called by setup_arch) after
smp_store_cpu_info() had set it to the correct value.
Signed-off-by: Mike Travis <travis@sgi.com>
---
arch/x86_64/kernel/smpboot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux.orig/arch/x86_64/kernel/smpboot.c 2007-10-12 14:28:45.000000000 -0700
+++ linux/arch/x86_64/kernel/smpboot.c 2007-10-12 14:53:42.753508152 -0700
@@ -141,8 +141,8 @@ static void __cpuinit smp_store_cpu_info
struct cpuinfo_x86 *c = &cpu_data(id);
*c = boot_cpu_data;
- c->cpu_index = id;
identify_cpu(c);
+ c->cpu_index = id;
print_cpu_info(c);
}
--
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] x86: convert-cpuinfo_x86-array-to-a-per_cpu-array fix
2007-10-12 22:54 ` [PATCH 1/1] " travis
@ 2007-10-23 5:36 ` Yinghai Lu
2007-11-14 18:45 ` Mike Travis
1 sibling, 0 replies; 5+ messages in thread
From: Yinghai Lu @ 2007-10-23 5:36 UTC (permalink / raw)
To: travis@sgi.com
Cc: Andrew Morton, Suresh B Siddha, Christoph Lameter, linux-kernel,
linux-mm
On 10/12/07, travis@sgi.com <travis@sgi.com> wrote:
> This fix corrects the problem that early_identify_cpu() sets
> cpu_index to '0' (needed when called by setup_arch) after
> smp_store_cpu_info() had set it to the correct value.
>
> Signed-off-by: Mike Travis <travis@sgi.com>
> ---
> arch/x86_64/kernel/smpboot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux.orig/arch/x86_64/kernel/smpboot.c 2007-10-12 14:28:45.000000000 -0700
> +++ linux/arch/x86_64/kernel/smpboot.c 2007-10-12 14:53:42.753508152 -0700
> @@ -141,8 +141,8 @@ static void __cpuinit smp_store_cpu_info
> struct cpuinfo_x86 *c = &cpu_data(id);
>
> *c = boot_cpu_data;
> - c->cpu_index = id;
> identify_cpu(c);
> + c->cpu_index = id;
> print_cpu_info(c);
> }
>
why not removing assignment in early_identify_cpu?
YH
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] x86: convert-cpuinfo_x86-array-to-a-per_cpu-array fix
2007-10-12 22:54 ` [PATCH 1/1] " travis
2007-10-23 5:36 ` Yinghai Lu
@ 2007-11-14 18:45 ` Mike Travis
2007-11-20 7:55 ` Thomas Gleixner
1 sibling, 1 reply; 5+ messages in thread
From: Mike Travis @ 2007-11-14 18:45 UTC (permalink / raw)
To: Andrew Morton, Suresh B Siddha; +Cc: Christoph Lameter, linux-kernel, linux-mm
Hi Andrew,
It appears that this patch is missing from the latest 2.6.24 git kernel?
(Suresh noticed that it is still a problem.)
Thanks,
Mike
This fix corrects the problem that early_identify_cpu() sets
cpu_index to '0' (needed when called by setup_arch) after
smp_store_cpu_info() had set it to the correct value.
Signed-off-by: Mike Travis <travis@sgi.com>
---
arch/x86_64/kernel/smpboot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux.orig/arch/x86_64/kernel/smpboot.c 2007-10-12 14:28:45.000000000 -0700
+++ linux/arch/x86_64/kernel/smpboot.c 2007-10-12 14:53:42.753508152 -0700
@@ -141,8 +141,8 @@ static void __cpuinit smp_store_cpu_info
struct cpuinfo_x86 *c = &cpu_data(id);
*c = boot_cpu_data;
- c->cpu_index = id;
identify_cpu(c);
+ c->cpu_index = id;
print_cpu_info(c);
}
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] x86: convert-cpuinfo_x86-array-to-a-per_cpu-array fix
2007-11-14 18:45 ` Mike Travis
@ 2007-11-20 7:55 ` Thomas Gleixner
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Gleixner @ 2007-11-20 7:55 UTC (permalink / raw)
To: Mike Travis
Cc: Andrew Morton, Suresh B Siddha, Christoph Lameter, linux-kernel,
linux-mm
On Wed, 14 Nov 2007, Mike Travis wrote:
> Hi Andrew,
>
> It appears that this patch is missing from the latest 2.6.24 git kernel?
>
> (Suresh noticed that it is still a problem.)
>
> Thanks,
> Mike
>
> This fix corrects the problem that early_identify_cpu() sets
> cpu_index to '0' (needed when called by setup_arch) after
> smp_store_cpu_info() had set it to the correct value.
>
> Signed-off-by: Mike Travis <travis@sgi.com>
> ---
> arch/x86_64/kernel/smpboot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux.orig/arch/x86_64/kernel/smpboot.c 2007-10-12 14:28:45.000000000 -0700
> +++ linux/arch/x86_64/kernel/smpboot.c 2007-10-12 14:53:42.753508152 -0700
> @@ -141,8 +141,8 @@ static void __cpuinit smp_store_cpu_info
> struct cpuinfo_x86 *c = &cpu_data(id);
>
> *c = boot_cpu_data;
> - c->cpu_index = id;
> identify_cpu(c);
> + c->cpu_index = id;
> print_cpu_info(c);
> }
The correct fix is already in mainline:
commit 699d934d5f958d7944d195c03c334f28cc0b3669
tglx
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-11-20 7:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-12 22:54 [PATCH 0/1] x86: convert-cpuinfo_x86-array-to-a-per_cpu-array fix travis
2007-10-12 22:54 ` [PATCH 1/1] " travis
2007-10-23 5:36 ` Yinghai Lu
2007-11-14 18:45 ` Mike Travis
2007-11-20 7:55 ` Thomas Gleixner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).