[PATCH] slub: nr_slabs is an atomic_long_t

[PATCH] slub: nr_slabs is an atomic_long_t

[Stephen Rothwell]

so shouldn't be passed to atomic_read.

mm/slub.c: In function 'slab_mem_offline_callback':
mm/slub.c:2737: warning: passing argument 1 of 'atomic_read' from incompatible pointer type
mm/slub.c:2737: warning: passing argument 1 of 'atomic_read' from incompatible pointer type
mm/slub.c:2737: warning: passing argument 1 of 'atomic_read' from incompatible pointer type

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 mm/slub.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Seen on PowerPC allyesconfig build.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

diff --git a/mm/slub.c b/mm/slub.c
index aac1dd3..bcdb2c8 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -2734,7 +2734,7 @@ static void slab_mem_offline_callback(void *arg)
 			 * and offline_pages() function shoudn't call this
 			 * callback. So, we must fail.
 			 */
-			BUG_ON(atomic_read(&n->nr_slabs));
+			BUG_ON(atomic_long_read(&n->nr_slabs));
 
 			s->node[offline_node] = NULL;
 			kmem_cache_free(kmalloc_caches, n);
-- 
1.5.3.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] slub: nr_slabs is an atomic_long_t

[Christoph Lameter]

On Mon, 29 Oct 2007, Stephen Rothwell wrote:

> so shouldn't be passed to atomic_read.

That was already fixed AFAICT.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] slub: nr_slabs is an atomic_long_t

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 260 bytes --]

On Sun, 28 Oct 2007 19:53:55 -0700 (PDT) Christoph Lameter <clameter@sgi.com> wrote:
>
> That was already fixed AFAICT.

Not in Linus' tree, yet.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH] slub: nr_slabs is an atomic_long_t

[Olof Johansson]

On Mon, Oct 29, 2007 at 02:24:30PM +1100, Stephen Rothwell wrote:
> On Sun, 28 Oct 2007 19:53:55 -0700 (PDT) Christoph Lameter <clameter@sgi.com> wrote:
> >
> > That was already fixed AFAICT.
> 
> Not in Linus' tree, yet.

Nope, it's still sitting in -mm. Al Viro just posted the same fix too.


-Olof

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>