From: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
matthew@wil.cx, linux-arch@vger.kernel.org,
penberg@cs.helsinki.fi, linux-mm@kvack.org,
Christoph Lameter <clameter@sgi.com>
Subject: Re: [patch 04/28] Add cmpxchg64 and cmpxchg64_local to mips
Date: Wed, 31 Oct 2007 09:19:35 -0400 [thread overview]
Message-ID: <20071031131935.GA26625@Krystal> (raw)
In-Reply-To: <20071031124831.GA3982@linux-mips.org>
* Ralf Baechle (ralf@linux-mips.org) wrote:
> This implementation means cmpxchg64_local will also silently take 32-bit
> arguments without making noises at compile time. I think it should.
>
Something along those lines ? I've fixed the other architectures too.
Add cmpxchg64 and cmpxchg64_local to mips
Make sure that at least cmpxchg64_local is available on all architectures to use
for unsigned long long values.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
CC: ralf@linux-mips.org
CC linux-mips@linux-mips.org
---
include/asm-mips/cmpxchg.h | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
Index: linux-2.6-lttng/include/asm-mips/cmpxchg.h
===================================================================
--- linux-2.6-lttng.orig/include/asm-mips/cmpxchg.h 2007-10-31 09:14:10.000000000 -0400
+++ linux-2.6-lttng/include/asm-mips/cmpxchg.h 2007-10-31 09:15:35.000000000 -0400
@@ -104,4 +104,21 @@ extern void __cmpxchg_called_with_bad_po
#define cmpxchg(ptr, old, new) __cmpxchg(ptr, old, new, smp_llsc_mb())
#define cmpxchg_local(ptr, old, new) __cmpxchg(ptr, old, new, )
+#define cmpxchg64(ptr,o,n) \
+ ({ \
+ BUILD_BUG_ON(sizeof(*(ptr)) != 8); \
+ cmpxchg((ptr),(o),(n)); \
+ })
+
+#ifdef CONFIG_64BIT
+#define cmpxchg64_local(ptr,o,n) \
+ ({ \
+ BUILD_BUG_ON(sizeof(*(ptr)) != 8); \
+ cmpxchg_local((ptr),(o),(n)); \
+ })
+#else
+#include <asm-generic/cmpxchg-local.h>
+#define cmpxchg64_local(ptr,o,n) __cmpxchg64_local_generic((ptr),(o),(n))
+#endif
+
#endif /* __ASM_CMPXCHG_H */
--
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-10-31 13:19 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-30 19:15 [patch 00/28] cmpxchg_local standardization across architectures Mathieu Desnoyers
2007-10-30 19:15 ` [patch 01/28] Add cmpxchg_local to asm-generic for per cpu atomic operations Mathieu Desnoyers
2007-10-30 19:15 ` [patch 02/28] Fall back on interrupt disable in cmpxchg8b on 80386 and 80486 Mathieu Desnoyers
2007-10-30 19:16 ` [patch 03/28] Add cmpxchg64 and cmpxchg64_local to alpha Mathieu Desnoyers
2007-10-30 19:16 ` [patch 04/28] Add cmpxchg64 and cmpxchg64_local to mips Mathieu Desnoyers
2007-10-31 12:48 ` Ralf Baechle
2007-10-31 13:19 ` Mathieu Desnoyers [this message]
2007-10-31 18:36 ` Ralf Baechle
2007-10-30 19:16 ` [patch 05/28] Add cmpxchg64 and cmpxchg64_local to powerpc Mathieu Desnoyers
2007-10-30 19:16 ` [patch 06/28] Add cmpxchg64 and cmpxchg64_local to x86_64 Mathieu Desnoyers
2007-10-30 19:16 ` [patch 07/28] Add cmpxchg_local to arm Mathieu Desnoyers
2007-10-30 19:16 ` [patch 08/28] Add cmpxchg_local to avr32 Mathieu Desnoyers
2007-10-30 19:16 ` [patch 09/28] Add cmpxchg_local to blackfin, replace __cmpxchg by generic cmpxchg Mathieu Desnoyers
2007-10-30 19:16 ` [patch 10/28] Add cmpxchg_local to cris Mathieu Desnoyers
2007-10-30 19:16 ` [patch 11/28] Add cmpxchg_local to frv Mathieu Desnoyers
2007-10-30 19:16 ` [patch 12/28] Add cmpxchg_local to h8300 Mathieu Desnoyers
2007-10-30 19:16 ` [patch 13/28] Add cmpxchg_local, cmpxchg64 and cmpxchg64_local to ia64 Mathieu Desnoyers
2007-10-30 19:16 ` [patch 14/28] New cmpxchg_local (optimized for UP case) for m32r Mathieu Desnoyers
2007-10-30 19:16 ` [patch 15/28] Fix m32r __xchg Mathieu Desnoyers
2007-10-30 19:16 ` [patch 16/28] m32r: build fix of arch/m32r/kernel/smpboot.c Mathieu Desnoyers
2007-10-30 19:16 ` [patch 17/28] local_t m32r use architecture specific cmpxchg_local Mathieu Desnoyers
2007-10-30 19:16 ` [patch 18/28] Add cmpxchg_local to m86k Mathieu Desnoyers
2007-10-30 19:16 ` [patch 19/28] Add cmpxchg_local to m68knommu Mathieu Desnoyers
2007-10-30 19:16 ` [patch 20/28] Add cmpxchg_local to parisc Mathieu Desnoyers
2007-10-30 19:16 ` [patch 21/28] Add cmpxchg_local to ppc Mathieu Desnoyers
2007-10-30 19:16 ` [patch 22/28] Add cmpxchg_local to s390 Mathieu Desnoyers
2007-10-30 19:16 ` [patch 23/28] Add cmpxchg_local to sh, use generic cmpxchg() instead of cmpxchg_u32 Mathieu Desnoyers
2007-10-30 19:16 ` [patch 24/28] Add cmpxchg_local to sh64 Mathieu Desnoyers
2007-10-30 19:16 ` [patch 25/28] Add cmpxchg_local to sparc, move __cmpxchg to system.h Mathieu Desnoyers
2007-10-30 19:16 ` [patch 26/28] Add cmpxchg_local to sparc64 Mathieu Desnoyers
2007-10-30 19:16 ` [patch 27/28] Add cmpxchg_local to v850 Mathieu Desnoyers
2007-10-30 19:16 ` [patch 28/28] Add cmpxchg_local to xtensa Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071031131935.GA26625@Krystal \
--to=mathieu.desnoyers@polymtl.ca \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew@wil.cx \
--cc=penberg@cs.helsinki.fi \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).