From: Marcelo Tosatti <marcelo@kvack.org>
To: Dave Jones <davej@redhat.com>
Cc: Marcelo Tosatti <marcelo@kvack.org>,
linux-mm@kvack.org, drepper@redhat.com, riel@redhat.com,
akpm@linux-foundation.org, mbligh@mbligh.org,
balbir@linux.vnet.ibm.com
Subject: Re: [RFC] oom notifications via /dev/oom_notify
Date: Thu, 1 Nov 2007 19:58:43 -0400 [thread overview]
Message-ID: <20071101235843.GA11213@dmt> (raw)
In-Reply-To: <20071031172010.GA6005@redhat.com>
On Wed, Oct 31, 2007 at 01:20:10PM -0400, Dave Jones wrote:
> On Tue, Oct 30, 2007 at 05:07:43PM -0400, Marcelo Tosatti wrote:
> > + case 13:
> > + filp->f_op = &oom_notify_fops;
> > + break;
>
> Don't forget to add this to Documentation/devices.txt
Done.
> > + while (cpu < NR_CPUS) {
> > + struct vm_event_state *this = &per_cpu(vm_event_states, cpu);
> > +
> > + cpu = next_cpu(cpu, *cpumask);
> > +
> > + if (cpu < NR_CPUS)
> > + prefetch(&per_cpu(vm_event_states, cpu));
> > +
> > + ret += this->event[vm_event];
> > + }
> > + return ret;
> > +}
>
> Is the prefetching worth it?
Taking into account that this is a generic function and as such any
member of this->event[] might be accessed, no... removed.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-11-01 23:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-30 19:18 [RFC] oom notifications via /dev/oom_notify Marcelo Tosatti
2007-10-30 20:57 ` Balbir Singh
2007-10-30 22:16 ` Marcelo Tosatti
2007-10-30 21:00 ` Rik van Riel
2007-10-30 21:07 ` Marcelo Tosatti
2007-10-30 21:19 ` Rik van Riel
2007-10-30 22:26 ` Marcelo Tosatti
2007-10-31 17:20 ` Dave Jones
2007-11-01 23:58 ` Marcelo Tosatti [this message]
2007-10-30 21:59 ` Badari Pulavarty
2007-10-30 21:12 ` Rik van Riel
2007-10-31 4:17 ` Badari
2007-10-31 4:31 ` Rik van Riel
2007-10-31 17:01 ` Badari Pulavarty
2007-10-31 16:15 ` Rik van Riel
2007-10-31 5:38 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071101235843.GA11213@dmt \
--to=marcelo@kvack.org \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=davej@redhat.com \
--cc=drepper@redhat.com \
--cc=linux-mm@kvack.org \
--cc=mbligh@mbligh.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).