Re: [RFC][PATCH 2/2] Revert "hugetlb: Add hugetlb_dynamic_pool sysctl"

[Nishanth Aravamudan <nacc@us.ibm.com>]

On 13.12.2007 [00:53:46 -0800], William Lee Irwin III wrote:
> On Wed, Dec 12, 2007 at 11:42:59PM -0800, Nishanth Aravamudan wrote:
> > Revert "hugetlb: Add hugetlb_dynamic_pool sysctl"
> > This reverts commit 54f9f80d6543fb7b157d3b11e2e7911dc1379790.
> > Given the new sysctl nr_overcommit_hugepages, the boolean dynamic pool
> > sysctl is not needed, as its semantics can be expressed by 0 in the
> > overcommit sysctl (no dynamic pool) and non-0 in the overcommit sysctl
> > (pool enabled).
> > Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
> 
> This is recent enough that dependencies shouldn't have developed, but
> it'd be nice to stage user-visible API/ABI changes more consciously
> and carefully in the future. Or at least we should try to avoid the
> sorts of situations where we end up changing recently introduced
> user/kernel ABI's and API's shortly after merging. We'll run the risk
> of getting stuck with a user/kernel ABI we can't abandon for years on
> account of not fixing it up before dependencies develop if this
> happens too often.

I agree and I apologize if I'm making things hard for everyone. However,
I hadn't fully considered the implications of the dynamic pool for my
other patches. The patches moved from -mm to -linus rather quickly,
iirc. No excuse, however, I should have been paying more attention.

If folks really don't want things to change, I guess we could also just
make the sysctl's per-node corresponding attribute be a boolean too. It
just seems less flexible than this approach.

Thanks,
Nish

-- 
Nishanth Aravamudan <nacc@us.ibm.com>
IBM Linux Technology Center

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>