From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e3.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id lBDGlTZU000727 for ; Thu, 13 Dec 2007 11:47:29 -0500 Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id lBDGlTG8489550 for ; Thu, 13 Dec 2007 11:47:29 -0500 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id lBDGlTWT022173 for ; Thu, 13 Dec 2007 11:47:29 -0500 Date: Thu, 13 Dec 2007 08:47:27 -0800 From: Nishanth Aravamudan Subject: Re: [RFC][PATCH 2/2] Revert "hugetlb: Add hugetlb_dynamic_pool sysctl" Message-ID: <20071213164727.GD17526@us.ibm.com> References: <20071213074156.GA17526@us.ibm.com> <20071213074259.GB17526@us.ibm.com> <20071213085346.GC31637@holomorphy.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071213085346.GC31637@holomorphy.com> Sender: owner-linux-mm@kvack.org Return-Path: To: William Lee Irwin III Cc: agl@us.ibm.com, mel@csn.ul.ie, apw@shadowen.org, akpm@linux-foundation.org, lee.schermerhorn@hp.com, linux-mm@kvack.org List-ID: On 13.12.2007 [00:53:46 -0800], William Lee Irwin III wrote: > On Wed, Dec 12, 2007 at 11:42:59PM -0800, Nishanth Aravamudan wrote: > > Revert "hugetlb: Add hugetlb_dynamic_pool sysctl" > > This reverts commit 54f9f80d6543fb7b157d3b11e2e7911dc1379790. > > Given the new sysctl nr_overcommit_hugepages, the boolean dynamic pool > > sysctl is not needed, as its semantics can be expressed by 0 in the > > overcommit sysctl (no dynamic pool) and non-0 in the overcommit sysctl > > (pool enabled). > > Signed-off-by: Nishanth Aravamudan > > This is recent enough that dependencies shouldn't have developed, but > it'd be nice to stage user-visible API/ABI changes more consciously > and carefully in the future. Or at least we should try to avoid the > sorts of situations where we end up changing recently introduced > user/kernel ABI's and API's shortly after merging. We'll run the risk > of getting stuck with a user/kernel ABI we can't abandon for years on > account of not fixing it up before dependencies develop if this > happens too often. I agree and I apologize if I'm making things hard for everyone. However, I hadn't fully considered the implications of the dynamic pool for my other patches. The patches moved from -mm to -linus rather quickly, iirc. No excuse, however, I should have been paying more attention. If folks really don't want things to change, I guess we could also just make the sysctl's per-node corresponding attribute be a boolean too. It just seems less flexible than this approach. Thanks, Nish -- Nishanth Aravamudan IBM Linux Technology Center -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org