Re: [RFC][PATCH 1/2] hugetlb: introduce nr_overcommit_hugepages sysctl

[Nishanth Aravamudan <nacc@us.ibm.com>]

On 12.12.2007 [23:41:56 -0800], Nishanth Aravamudan wrote:
> hugetlb: introduce nr_overcommit_hugepages sysctl

<snip>

> diff --git a/kernel/sysctl.c b/kernel/sysctl.c
> index 8ac5171..b85a128 100644
> --- a/kernel/sysctl.c
> +++ b/kernel/sysctl.c
> @@ -912,6 +912,14 @@ static struct ctl_table vm_table[] = {
>  		.mode		= 0644,
>  		.proc_handler	= &proc_dointvec,
>  	},
> +	{
> +		.ctl_name	= CTL_UNNUMBERED,
> +		.procname	= "nr_overcommit_hugepages",
> +		.data		= &nr_overcommit_huge_pages,
> +		.maxlen		= sizeof(nr_overcommit_huge_pages),
> +		.mode		= 0644,
> +		.proc_handler	= &proc_doulongvec_minmax,
> +	},

Dave's reply regarding the sysctl documentation, while unrelated to this
hunk, did remind me of something I wanted to ask. Having looked at
proc_doulongvec_minmax() a bit, it seems like I'm ok not specifying a
min and max, as the code checks to see if the min and max are specified.
Essentially, I want to allow any unsigned long value. Does this seem ok?
(there doesn't seem to be a proc_doulongvec() like there is
proc_dointvec().

Thanks,
Nish

-- 
Nishanth Aravamudan <nacc@us.ibm.com>
IBM Linux Technology Center

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>