From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e34.co.us.ibm.com (8.13.8/8.13.8) with ESMTP id m0A3QkFw025257 for ; Wed, 9 Jan 2008 22:26:46 -0500 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m0A3QftZ121204 for ; Wed, 9 Jan 2008 20:26:46 -0700 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m0A3QeoK018894 for ; Wed, 9 Jan 2008 20:26:40 -0700 Date: Thu, 10 Jan 2008 08:56:31 +0530 From: Balbir Singh Subject: Re: [patch 05/19] split LRU lists into anon & file sets Message-ID: <20080110032631.GE15547@balbir.in.ibm.com> Reply-To: balbir@linux.vnet.ibm.com References: <20080108205939.323955454@redhat.com> <20080108210002.638347207@redhat.com> <20080109134132.ba7bb33c.kamezawa.hiroyu@jp.fujitsu.com> <20080110022133.GC15547@balbir.in.ibm.com> <20080110113618.f967d215.kamezawa.hiroyu@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20080110113618.f967d215.kamezawa.hiroyu@jp.fujitsu.com> Sender: owner-linux-mm@kvack.org Return-Path: To: KAMEZAWA Hiroyuki Cc: Rik van Riel , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Lee Schermerhorn List-ID: * KAMEZAWA Hiroyuki [2008-01-10 11:36:18]: > On Thu, 10 Jan 2008 07:51:33 +0530 > Balbir Singh wrote: > > > > > #define PAGE_CGROUP_FLAG_CACHE (0x1) /* charged as cache */ > > > > #define PAGE_CGROUP_FLAG_ACTIVE (0x2) /* page is active in this cgroup */ > > > > +#define PAGE_CGROUP_FLAG_FILE (0x4) /* page is file system backed */ > > > > > > > > > > Now, we don't have control_type and a feature for accounting only CACHE. > > > Balbir-san, do you have some new plan ? > > > > > > > Hi, KAMEZAWA-San, > > > > The control_type feature is gone. We still have cached page > > accounting, but we do not allow control of only RSS pages anymore. We > > need to control both RSS+cached pages. I do not understand your > > question about new plan? Is it about adding back control_type? > > > Ah, just wanted to confirm that we can drop PAGE_CGROUP_FLAG_CACHE > if page_file_cache() function and split-LRU is introduced. > Earlier we would have had a problem, since we even accounted for swap cache with PAGE_CGROUP_FLAG_CACHE and I think page_file_cache() does not account swap cache pages with page_file_cache(). Our accounting is based on mapped vs unmapped whereas the new code from Rik accounts file vs anonymous. I suspect we could live a little while longer with PAGE_CGROUP_FLAG_CACHE and then if we do not need it at all, we can mark it down for removal. What do you think? -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org