From: David Miller <davem@davemloft.net>
From: travis@sgi.com
To: travis@sgi.com
Cc: akpm@linux-foundation.org, ak@suse.de, mingo@elte.hu,
clameter@sgi.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, rusty@rustcorp.com.au
Subject: Re: [PATCH 1/7] Modules: Fold percpu_modcopy into module.c
Date: Mon, 21 Jan 2008 00:08:20 -0800 (PST)
Date: Fri, 18 Jan 2008 10:29:54 -0800 [thread overview]
Message-ID: <20080121.000820.194841023.davem@davemloft.net> (raw)
In-Reply-To: <20080118182953.922370000@sgi.com>
> percpu_modcopy() is defined multiple times in arch files. However, the only
> user is module.c. Put a static definition into module.c and remove
> the definitions from the arch files.
>
> Cc: Rusty Russell <rusty@rustcorp.com.au>
> Cc: Andi Kleen <ak@suse.de>
> Signed-off-by: Christoph Lameter <clameter@sgi.com>
> Signed-off-by: Mike Travis <travis@sgi.com>
This doesn't build on sparc64.
The percpu_modcopy() removal from include/asm-sparc64/percpu.h
leaked into patch #3 instead of being done here in patch #1
where it belongs (so that this series is properly bisectable).
It also seems that the include/asm-x86/percpu_{32,64}.h defines
aren't removed in this patch either.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-01-21 8:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-18 18:29 [PATCH 0/7] percpu: Per cpu code simplification fixup travis
2008-01-18 18:29 ` [PATCH 1/7] Modules: Fold percpu_modcopy into module.c travis
2008-01-18 19:46 ` Rusty Russell
2008-01-21 8:08 ` David Miller, travis [this message]
2008-01-21 15:41 ` Mike Travis
2008-01-18 18:29 ` [PATCH 2/7] percpu: Change Kconfig ARCH_SETS_UP_PER_CPU_AREA to HAVE_SETUP_PER_CPU_AREA travis
2008-01-18 18:29 ` [PATCH 3/7] Sparc64: Use generic percpu travis
2008-01-18 18:29 ` [PATCH 4/7] ia64: " travis
2008-01-18 18:29 ` [PATCH 5/7] Powerpc: Use generic per cpu travis
2008-01-18 18:29 ` [PATCH 6/7] s390: Use generic percpu travis
2008-01-18 18:30 ` [PATCH 7/7] percpu: Add debug detection of uninitialized usage of per_cpu variable travis
2008-01-18 20:39 ` [PATCH 0/7] percpu: Per cpu code simplification fixup Ingo Molnar
2008-01-18 20:51 ` Mike Travis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080121.000820.194841023.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=rusty@rustcorp.com.au \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).