From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 21 Jan 2008 00:08:20 -0800 (PST) Message-Id: <20080121.000820.194841023.davem@davemloft.net> Subject: Re: [PATCH 1/7] Modules: Fold percpu_modcopy into module.c From: David Miller In-Reply-To: <20080118182953.922370000@sgi.com> References: <20080118182953.748071000@sgi.com> <20080118182953.922370000@sgi.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org From: travis@sgi.com Date: Fri, 18 Jan 2008 10:29:54 -0800 Return-Path: To: travis@sgi.com Cc: akpm@linux-foundation.org, ak@suse.de, mingo@elte.hu, clameter@sgi.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, rusty@rustcorp.com.au List-ID: > percpu_modcopy() is defined multiple times in arch files. However, the only > user is module.c. Put a static definition into module.c and remove > the definitions from the arch files. > > Cc: Rusty Russell > Cc: Andi Kleen > Signed-off-by: Christoph Lameter > Signed-off-by: Mike Travis This doesn't build on sparc64. The percpu_modcopy() removal from include/asm-sparc64/percpu.h leaked into patch #3 instead of being done here in patch #1 where it belongs (so that this series is properly bisectable). It also seems that the include/asm-x86/percpu_{32,64}.h defines aren't removed in this patch either. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org