From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 31 Jan 2008 13:31:18 +0100 From: Andrea Arcangeli Subject: Re: [patch 2/3] mmu_notifier: Callbacks to invalidate address ranges Message-ID: <20080131123118.GK7185@v2.random> References: <20080131045750.855008281@sgi.com> <20080131045812.785269387@sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080131045812.785269387@sgi.com> Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: Robin Holt , Avi Kivity , Izik Eidus , kvm-devel@lists.sourceforge.net, Peter Zijlstra , steiner@sgi.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, daniel.blueman@quadrics.com List-ID: On Wed, Jan 30, 2008 at 08:57:52PM -0800, Christoph Lameter wrote: > @@ -211,7 +212,9 @@ asmlinkage long sys_remap_file_pages(uns > spin_unlock(&mapping->i_mmap_lock); > } > > + mmu_notifier(invalidate_range_begin, mm, start, start + size, 0); > err = populate_range(mm, vma, start, size, pgoff); > + mmu_notifier(invalidate_range_end, mm, 0); > if (!err && !(flags & MAP_NONBLOCK)) { > if (unlikely(has_write_lock)) { > downgrade_write(&mm->mmap_sem); This can't be enough for GRU, infact it can't work for KVM either. You got 1) to have some invalidate_page for GRU before freeing the page, and 2) to pass start, end to range_end (if you want kvm to use it instead of invalidate_page). mremap still missing as a whole. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org