From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 31 Jan 2008 19:56:12 -0600 From: Jack Steiner Subject: Re: [patch 1/3] mmu_notifier: Core code Message-ID: <20080201015611.GA15893@sgi.com> References: <20080131045750.855008281@sgi.com> <20080131045812.553249048@sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080131045812.553249048@sgi.com> Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: Andrea Arcangeli , Robin Holt , Avi Kivity , Izik Eidus , kvm-devel@lists.sourceforge.net, Peter Zijlstra , linux-kernel@vger.kernel.org, linux-mm@kvack.org, daniel.blueman@quadrics.com List-ID: > @@ -2033,6 +2034,7 @@ void exit_mmap(struct mm_struct *mm) > unsigned long end; > > /* mm's last user has gone, and its about to be pulled down */ > + mmu_notifier(invalidate_all, mm, 0); > arch_exit_mmap(mm); > The name of the "invalidate_all" callout is not very descriptive. Why not use "exit_mmap". That matches the function name, the arch callout and better describes what is happening. --- jack -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org