From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: Re: Fastpath prototype? Date: Tue, 12 Feb 2008 11:40:11 +0100 References: <20080211235607.GA27320@wotan.suse.de> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200802121140.12040.ak@suse.de> Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: Nick Piggin , Andrew Morton , Mel Gorman , linux-mm@kvack.org, Pekka J Enberg List-ID: On Tuesday 12 February 2008 07:06:48 Christoph Lameter wrote: > This patch preserves the performance while only needing order 0 allocs. > Pretty primitive. The per CPU caches in the zone were originally intended to be exactly such a fast path. That is why I find your patch pretty ironic. I can understand it because a lot of the page_alloc.c code is frankly bizarre now (the file could probably really need a rewrite) and it doesn't surprise me that the old fast path is not very fast anymore. But if you add another fast path you should first remove the old one at least. -Andi -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org