From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Christoph Lameter <clameter@sgi.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
Mel Gorman <mel@csn.ul.ie>
Subject: Re: [patch 0/3] Hotcold removal completion
Date: Tue, 12 Feb 2008 17:32:29 +1100 [thread overview]
Message-ID: <200802121732.29593.nickpiggin@yahoo.com.au> (raw)
In-Reply-To: <20080212003643.536643832@sgi.com>
On Tuesday 12 February 2008 11:36, Christoph Lameter wrote:
> The patch that we had in mm for the removal of the cold page queue was
> merged.
That patch to merge the hot and cold lists has obvious problems.
It pulls cold pages off the list in the opposite order that hot
pages come off the list (which is obviously bad); and also it
allows cold allocations to deplete hot pages (which may not be a
good idea).
Obviously the half baked code that's there now should be fixed...
But whether it is to fix hot/cold properly, or to remove it
completely, I don't really know.
> However, there were 3 more pages that I think are necessary to
> complete the work. Mel's testing indicated that the patch in mm is inferior
> to simply removing the hot cold distinction in the VM altogether
> (see http://marc.info/?t=119507025400001&r=1&w=2).
>
> These 3 patches get rid of cold page handling in the VM.
I'm all in favour of removing these. But honestly, I don't think
kernbench, [td]bench, and aim9 are really great tests when it
comes to subtle cache behaviour... OTOH, that didn't stop the
last patch being merged. May as well do it.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-02-12 6:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-12 0:36 [patch 0/3] Hotcold removal completion Christoph Lameter
2008-02-12 0:36 ` [patch 1/3] Eliminate the hot/cold distinction in the page allocator Christoph Lameter
2008-02-12 0:36 ` [patch 2/3] Remove GFP_COLD Christoph Lameter
2008-02-12 0:36 ` [patch 3/3] Remove cold field from pagevec Christoph Lameter
2008-02-12 6:32 ` Nick Piggin [this message]
2008-02-12 7:57 ` [patch 0/3] Hotcold removal completion Andrew Morton
2008-02-12 20:12 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802121732.29593.nickpiggin@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).