linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Paul Jackson <pj@sgi.com>
To: Nick Piggin <npiggin@suse.de>
Cc: clameter@sgi.com, akpm@linux-foundation.org, mel@csn.ul.ie,
	linux-mm@kvack.org, penberg@cs.helsinki.fi
Subject: Re: SLUB tbench regression due to page allocator deficiency
Date: Wed, 13 Feb 2008 12:33:22 -0600	[thread overview]
Message-ID: <20080213123322.e1c202e6.pj@sgi.com> (raw)
In-Reply-To: <20080211235607.GA27320@wotan.suse.de>

Nick, listing things __alloc_pages() does:
> cpuset -- zone softwall stuff

That should be off the fast path.  So long as there is enough memory
(above watermarks on some node in current->mems_allowed) then there
should be no need to consider the cpuset softwall details.  Notice
that the first invocation of get_page_from_freelist() in __alloc_pages()
has the __GFP_HARDWALL included, bypassing the cpuset software code.

==

Is there someway to get profiling data from __alloc_pages() and
get_page_from_freelist(), for Christoph's test case.  I am imagining
publishing a listing of that code, with a column to the right
indicating how many times each line of code was executed, during the
interesting portion of running such a test case.

That would shine a bright light on any line(s) of code that get
executed way more often than seem necessary for such a load, and enable
the cast of dozens of us who have hacked this code at sometime to
notice opportunities for sucking less.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.940.382.4214

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2008-02-13 18:33 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-09 21:45 SLUB tbench regression due to page allocator deficiency Christoph Lameter
2008-02-09 22:35 ` Andrew Morton
2008-02-10  0:19   ` Christoph Lameter
2008-02-10  2:45     ` Nick Piggin
2008-02-10  3:36       ` Christoph Lameter
2008-02-10  3:39       ` Christoph Lameter
2008-02-10 23:24         ` Nick Piggin
2008-02-11 19:14           ` Christoph Lameter
2008-02-11 22:03           ` Christoph Lameter
2008-02-11  7:18         ` Nick Piggin
2008-02-11 19:21           ` Christoph Lameter
2008-02-11 23:40             ` Nick Piggin
2008-02-11 23:42               ` Christoph Lameter
2008-02-11 23:56                 ` Nick Piggin
2008-02-12  0:08                   ` Christoph Lameter
2008-02-12  6:06                   ` Fastpath prototype? Christoph Lameter
2008-02-12 10:40                     ` Andi Kleen
2008-02-12 20:10                       ` Christoph Lameter
2008-02-12 22:31                         ` Christoph Lameter
2008-02-13 11:38                           ` Andi Kleen
2008-02-13 20:09                             ` Christoph Lameter
2008-02-13 18:33                   ` Paul Jackson [this message]
2008-02-11 13:50 ` SLUB tbench regression due to page allocator deficiency Mel Gorman
2008-02-13 11:15 ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080213123322.e1c202e6.pj@sgi.com \
    --to=pj@sgi.com \
    --cc=akpm@linux-foundation.org \
    --cc=clameter@sgi.com \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    --cc=npiggin@suse.de \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).