From: Andrew Morton <akpm@linux-foundation.org>
To: balbir@linux.vnet.ibm.com
Cc: menage@google.com, xemul@openvz.org, balbir@in.ibm.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 2/2] ResCounter: Use read_uint in memory controller
Date: Sat, 23 Feb 2008 00:04:26 -0800 [thread overview]
Message-ID: <20080223000426.adf5c75a.akpm@linux-foundation.org> (raw)
In-Reply-To: <47BE4FB5.5040902@linux.vnet.ibm.com>
On Fri, 22 Feb 2008 09:59:41 +0530 Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
> menage@google.com wrote:
> > Update the memory controller to use read_uint for its
> > limit/usage/failcnt control files, calling the new
> > res_counter_read_uint() function.
> >
> > Signed-off-by: Paul Menage <menage@google.com>
> >
>
> Hi, Paul,
>
> Looks good, except for the name uint(), can we make it u64(). Integers are 32
> bit on both ILP32 and LP64, but we really read/write 64 bit values.
>
yup, I agree. Even though I don't know what ILP32 and LP64 are ;)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-02-23 8:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-21 20:35 [PATCH 0/2] ResCounter: Add res_counter_read_uint and use it in memory cgroup menage
2008-02-21 20:35 ` [PATCH 1/2] ResCounter: Add res_counter_read_uint() menage
2008-02-21 20:35 ` [PATCH 2/2] ResCounter: Use read_uint in memory controller menage
2008-02-22 4:29 ` Balbir Singh
2008-02-23 8:04 ` Andrew Morton [this message]
2008-02-23 8:18 ` KOSAKI Motohiro
2008-02-23 9:16 ` Balbir Singh
2008-02-23 14:33 ` Paul Menage
2008-02-23 18:59 ` Andrew Morton
2008-02-24 2:47 ` Balbir Singh
2008-02-24 3:06 ` Paul Menage
2008-02-22 7:51 ` Pavel Emelyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080223000426.adf5c75a.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=balbir@in.ibm.com \
--cc=balbir@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=menage@google.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).