linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Christoph Lameter <clameter@sgi.com>,
	linux-mm@kvack.org, Mel Gorman <mel@skynet.ie>,
	andi@firstfloor.org
Subject: Re: [patch 00/17] Slab Fragmentation Reduction V10
Date: Sat, 23 Feb 2008 15:20:55 +0100	[thread overview]
Message-ID: <20080223142055.GA6745@one.firstfloor.org> (raw)
In-Reply-To: <20080223000722.a37983eb.akpm@linux-foundation.org>

I personally would really like to see d/icache fragmentation in
one form or another. It's a serious long standing Linux issue
that would be really good to solve finally.

> So I think the first thing we need to do is to establish that slub is
> viable as our only slab allocator (ignoring slob here).  And if that means
> tweaking the heck out of slub until it's competitive, we would be
> duty-bound to ask "how fast will slab be if we do that much tweaking to
> it as well".

There's another aspect: slab is quite unreadable and very hairy code.
slub is much cleaner. On the maintainability front slub wins easily. 

> Another basis for comparison is "which one uses the lowest-order
> allocations to achieve its performance".

That's an important point I agree. It directly translates into
reliability under load and that is very important.

> But one of these implementations needs to go away, and that decision

I don't think slab is a good candidate to keep because it's so hard 
to hack on. Especially since the slab NUMA changes the code flow and
data structures are really really hairy and I doubt there are many people 
left who understand it. e.g. I tracked down an RT bug in slab some
time ago and it was a really unpleasant experience.

In the end even if it is slightly slower today the code
that is easiest to improve will be faster/better longer term.

I'm a little sceptical about the high order allocations in slub too 
though. Christoph seems to think they're not a big deal, but that is 
against a lot of conventional Linux wisdom at least.

That is one area that probably needs to be explored more.

-Andi

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-02-23 14:20 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-16  0:45 [patch 00/17] Slab Fragmentation Reduction V10 Christoph Lameter
2008-02-16  0:45 ` [patch 01/17] SLUB: Extend slabinfo to support -D and -F options Christoph Lameter
2008-02-16  0:45 ` [patch 02/17] SLUB: Add defrag_ratio field and sysfs support Christoph Lameter
2008-02-16  0:45 ` [patch 03/17] SLUB: Replace ctor field with ops field in /sys/slab/* Christoph Lameter
2008-02-16  0:45 ` [patch 04/17] SLUB: Add get() and kick() methods Christoph Lameter
2008-02-16  0:45 ` [patch 05/17] SLUB: Sort slab cache list and establish maximum objects for defrag slabs Christoph Lameter
2008-02-16  0:45 ` [patch 06/17] SLUB: Slab defrag core Christoph Lameter
2008-02-16  0:45 ` [patch 07/17] SLUB: Add KICKABLE to avoid repeated kick() attempts Christoph Lameter
2008-02-16  0:45 ` [patch 08/17] SLUB: Trigger defragmentation from memory reclaim Christoph Lameter
2008-02-16  0:45 ` [patch 09/17] Buffer heads: Support slab defrag Christoph Lameter
2008-02-16  0:45 ` [patch 10/17] inodes: Support generic defragmentation Christoph Lameter
2008-02-16  0:45 ` [patch 11/17] FS: ExtX filesystem defrag Christoph Lameter
2008-02-16  0:45 ` [patch 12/17] FS: XFS slab defragmentation Christoph Lameter
2008-02-16  0:45 ` [patch 13/17] FS: Proc filesystem support for slab defrag Christoph Lameter
2008-02-16  0:45 ` [patch 14/17] FS: Slab defrag: Reiserfs support Christoph Lameter
2008-02-16  0:45 ` [patch 15/17] FS: Socket inode defragmentation Christoph Lameter
2008-02-16  0:45 ` [patch 16/17] dentries: Add constructor Christoph Lameter
2008-02-16  0:45 ` [patch 17/17] dentries: dentry defragmentation Christoph Lameter
2008-02-23  8:07 ` [patch 00/17] Slab Fragmentation Reduction V10 Andrew Morton
2008-02-23 14:20   ` Andi Kleen [this message]
2008-02-27 19:22     ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080223142055.GA6745@one.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=akpm@linux-foundation.org \
    --cc=clameter@sgi.com \
    --cc=linux-mm@kvack.org \
    --cc=mel@skynet.ie \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).