Re: [patch 2/8] Kbuild: Create a way to create preprocessor constants from C expressions

[Andrew Morton <akpm@linux-foundation.org>]

On Wed, 05 Mar 2008 14:38:17 -0800 Christoph Lameter <clameter@sgi.com> wrote:

> The use of enums create constants that are not available to the preprocessor
> when building the kernel (f.e. MAX_NR_ZONES).
> 
> Arch code already has a way to export constants calculated to the
> preprocessor through the asm-offsets.c file. Generate something
> similar for the core kernel through kbuild.
> 

err, this patch needs help.

> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> +++ linux-2.6/include/linux/bounds.h	2008-02-29 19:29:50.000000000 -0800
> @@ -0,0 +1,10 @@
> +#ifndef __LINUX_BOUNDS_H__
> +#define __LINUX_BOUNDS_H__
> +/*
> + * DO NOT MODIFY.
> + *
> + * This file was generated by Kbuild
> + *
> + */
> +
> +#endif

a) I'm not sure that we should check in a file which is supposed to get
   overwritten at build-time.

b) Is this `make O=' friendly?

c)
	make mrproper
	make allmodconfig
	make

In file included from include/linux/mm.h:192,
                 from include/linux/suspend.h:11,
                 from arch/x86/kernel/asm-offsets_64.c:12,
                 from arch/x86/kernel/asm-offsets.c:4:
include/linux/page-flags.h:10:26: error: linux/bounds.h: No such file or directory

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>