From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: linux-mm@kvack.org
Cc: Hugh Dickins <hugh@veritas.com>,
Sudhir Kumar <skumar@linux.vnet.ibm.com>,
YAMAMOTO Takashi <yamamoto@valinux.co.jp>,
Paul Menage <menage@google.com>,
lizf@cn.fujitsu.com, linux-kernel@vger.kernel.org,
taka@valinux.co.jp, David Rientjes <rientjes@google.com>,
Pavel Emelianov <xemul@openvz.org>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: [RFC][1/3] Add user interface for virtual address space control
Date: Sun, 16 Mar 2008 22:59:53 +0530 [thread overview]
Message-ID: <20080316172953.8812.50482.sendpatchset@localhost.localdomain> (raw)
In-Reply-To: <20080316172942.8812.56051.sendpatchset@localhost.localdomain>
Add as_usage_in_bytes and as_limit_in_bytes interfaces. These provide
control over the total address space that the processes combined together
in the cgroup can grow upto. This functionality is analogous to
the RLIMIT_AS function of the getrlimit(2) and setrlimit(2) calls.
A as_res resource counter is added to the mem_cgroup structure. The
as_res counter handles all the accounting associated with the virtual
address space accounting and control of cgroups.
Signed-off-by: Balbir Singh <balbir@linux.vnet.ibm.com>
---
mm/memcontrol.c | 31 +++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff -puN mm/memcontrol.c~memory-controller-virtual-address-space-control-user-interface mm/memcontrol.c
--- linux-2.6.25-rc5/mm/memcontrol.c~memory-controller-virtual-address-space-control-user-interface 2008-03-16 22:57:38.000000000 +0530
+++ linux-2.6.25-rc5-balbir/mm/memcontrol.c 2008-03-16 22:57:38.000000000 +0530
@@ -128,6 +128,10 @@ struct mem_cgroup {
*/
struct res_counter res;
/*
+ * Address space limits
+ */
+ struct res_counter as_res;
+ /*
* Per cgroup active and inactive list, similar to the
* per zone LRU lists.
*/
@@ -870,6 +874,21 @@ static ssize_t mem_cgroup_write(struct c
mem_cgroup_write_strategy);
}
+static u64 mem_cgroup_as_read(struct cgroup *cont, struct cftype *cft)
+{
+ return res_counter_read_u64(&mem_cgroup_from_cont(cont)->as_res,
+ cft->private);
+}
+
+static ssize_t mem_cgroup_as_write(struct cgroup *cont, struct cftype *cft,
+ struct file *file, const char __user *userbuf,
+ size_t nbytes, loff_t *ppos)
+{
+ return res_counter_write(&mem_cgroup_from_cont(cont)->as_res,
+ cft->private, userbuf, nbytes, ppos,
+ mem_cgroup_write_strategy);
+}
+
static ssize_t mem_force_empty_write(struct cgroup *cont,
struct cftype *cft, struct file *file,
const char __user *userbuf,
@@ -931,6 +950,17 @@ static struct cftype mem_cgroup_files[]
.read_u64 = mem_cgroup_read,
},
{
+ .name = "as_usage_in_bytes",
+ .private = RES_USAGE,
+ .read_u64 = mem_cgroup_as_read,
+ },
+ {
+ .name = "as_limit_in_bytes",
+ .private = RES_LIMIT,
+ .write = mem_cgroup_as_write,
+ .read_u64 = mem_cgroup_as_read,
+ },
+ {
.name = "failcnt",
.private = RES_FAILCNT,
.read_u64 = mem_cgroup_read,
@@ -999,6 +1029,7 @@ mem_cgroup_create(struct cgroup_subsys *
return ERR_PTR(-ENOMEM);
res_counter_init(&mem->res);
+ res_counter_init(&mem->as_res);
memset(&mem->info, 0, sizeof(mem->info));
diff -puN include/linux/memcontrol.h~memory-controller-virtual-address-space-control-user-interface include/linux/memcontrol.h
_
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-03-16 17:30 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-16 17:29 [RFC][0/3] Virtual address space control for cgroups Balbir Singh
2008-03-16 17:29 ` Balbir Singh [this message]
2008-03-16 17:30 ` [RFC][2/3] Account and control virtual address space allocations Balbir Singh
2008-03-17 2:02 ` Paul Menage
2008-03-17 2:57 ` Balbir Singh
2008-03-17 3:03 ` Paul Menage
2008-03-17 11:36 ` Pavel Emelyanov
2008-03-17 12:29 ` Balbir Singh
2008-03-17 12:40 ` Pavel Emelyanov
2008-03-17 12:51 ` Balbir Singh
2008-03-17 13:01 ` Pavel Emelyanov
2008-03-17 14:39 ` Balbir Singh
2008-03-17 16:53 ` Dave Hansen
2008-03-18 1:14 ` Balbir Singh
2008-03-18 17:11 ` Dave Hansen
2008-03-18 17:58 ` Balbir Singh
2008-03-17 23:35 ` YAMAMOTO Takashi
2008-03-18 1:10 ` Balbir Singh
2008-03-16 17:30 ` [RFC][3/3] Update documentation for virtual address space control Balbir Singh
2008-03-16 18:32 ` Randy Dunlap
2008-03-17 1:33 ` Balbir Singh
2008-03-16 23:26 ` [RFC][0/3] Virtual address space control for cgroups Paul Menage
2008-03-17 1:47 ` Li Zefan
2008-03-17 1:57 ` Paul Menage
2008-03-17 5:08 ` Balbir Singh
2008-03-17 5:22 ` Paul Menage
2008-03-17 15:15 ` Balbir Singh
2008-03-17 1:50 ` Balbir Singh
2008-03-17 1:55 ` Paul Menage
2008-03-17 3:12 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080316172953.8812.50482.sendpatchset@localhost.localdomain \
--to=balbir@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=hugh@veritas.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
--cc=rientjes@google.com \
--cc=skumar@linux.vnet.ibm.com \
--cc=taka@valinux.co.jp \
--cc=xemul@openvz.org \
--cc=yamamoto@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).