From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 18 Mar 2008 01:18:11 -0700 From: Andrew Morton Subject: Re: [patch 4/8] mm: allow not updating BDI stats in end_page_writeback() Message-Id: <20080318011811.252c7c59.akpm@linux-foundation.org> In-Reply-To: References: <20080317191908.123631326@szeredi.hu> <20080317191945.122011759@szeredi.hu> <20080317220431.a8507e29.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Miklos Szeredi Cc: a.p.zijlstra@chello.nl, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org List-ID: On Tue, 18 Mar 2008 09:11:49 +0100 Miklos Szeredi wrote: > > > > Reason: bdi_cap_writeback_dirty() is kinda weirdly intrepreted to mean > > various different things in different places and we really should separate > > its multiple interpretations into separate flags. > > > > Note that this becomes a standalone VFS cleanup patch, and the fuse code > > can then just use it later on. > > Hmm, I can see two slightly different meanings of bdi_cap_writeback_dirty(): > > 1) need to call ->writepage (sync_page_range(), ...) > 2) need to update BDI stats (test_clear_page_writeback(), ...) > > If these two were different flags, then fuse could set the > NEED_WRITEPAGE flag, but clear the NEED_UPDATE_BDI_STATS flag, and do > it manually. > > Does that sound workable? Yup, thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org