From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 24 Mar 2008 22:53:09 -0700 From: Andrew Morton Subject: Re: [PATCH] fix spurious EBUSY on memory cgroup removal Message-Id: <20080324225309.0a1ab8ec.akpm@linux-foundation.org> In-Reply-To: <20080325054713.948EF1E92EC@siro.lan> References: <20080325054713.948EF1E92EC@siro.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: YAMAMOTO Takashi Cc: balbir@linux.vnet.ibm.com, containers@lists.osdl.org, linux-mm@kvack.org, kamezawa.hiroyu@jp.fujitsu.com, minoura@valinux.co.jp List-ID: On Tue, 25 Mar 2008 14:47:13 +0900 (JST) yamamoto@valinux.co.jp (YAMAMOTO Takashi) wrote: > [ resending with To: akpm. Andrew, can you include this in -mm tree? ] Shouldn't it be in 2.6.25? > hi, > > the following patch is to fix spurious EBUSY on cgroup removal. > > YAMAMOTO Takashi > > > call mm_free_cgroup earlier. > otherwise a reference due to lazy mm switching can prevent cgroup removal. > > Signed-off-by: YAMAMOTO Takashi > Acked-by: Balbir Singh > --- > > --- linux-2.6.24-rc8-mm1/kernel/fork.c.BACKUP 2008-01-23 14:43:29.000000000 +0900 > +++ linux-2.6.24-rc8-mm1/kernel/fork.c 2008-01-31 17:26:31.000000000 +0900 > @@ -393,7 +393,6 @@ void __mmdrop(struct mm_struct *mm) > { > BUG_ON(mm == &init_mm); > mm_free_pgd(mm); > - mm_free_cgroup(mm); > destroy_context(mm); > free_mm(mm); > } > @@ -415,6 +414,7 @@ void mmput(struct mm_struct *mm) > spin_unlock(&mmlist_lock); > } > put_swap_token(mm); > + mm_free_cgroup(mm); > mmdrop(mm); > } > } -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org