linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Nick Piggin <npiggin@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: shaggy@austin.ibm.com, axboe@oracle.com, linux-mm@kvack.org,
	linux-arch@vger.kernel.org, torvalds@linux-foundation.org
Subject: [patch 1/2]: x86: implement pte_special
Date: Fri, 28 Mar 2008 03:55:41 +0100	[thread overview]
Message-ID: <20080328025541.GB8083@wotan.suse.de> (raw)
In-Reply-To: <20080328025455.GA8083@wotan.suse.de>

Implement the pte_special bit for x86. This is required to support lockless
get_user_pages, because we need to know whether or not we can refcount a
particular page given only its pte (and no vma).

Signed-off-by: Nick Piggin <npiggin@suse.de>
---
Index: linux-2.6/include/asm-x86/pgtable.h
===================================================================
--- linux-2.6.orig/include/asm-x86/pgtable.h
+++ linux-2.6/include/asm-x86/pgtable.h
@@ -18,6 +18,7 @@
 #define _PAGE_BIT_UNUSED1	9	/* available for programmer */
 #define _PAGE_BIT_UNUSED2	10
 #define _PAGE_BIT_UNUSED3	11
+#define _PAGE_BIT_SPECIAL	_PAGE_BIT_UNUSED1
 #define _PAGE_BIT_PAT_LARGE	12	/* On 2MB or 1GB pages */
 #define _PAGE_BIT_NX           63       /* No execute: only valid after cpuid check */
 
@@ -40,6 +41,8 @@
 #define _PAGE_UNUSED3	(_AC(1, L)<<_PAGE_BIT_UNUSED3)
 #define _PAGE_PAT	(_AC(1, L)<<_PAGE_BIT_PAT)
 #define _PAGE_PAT_LARGE (_AC(1, L)<<_PAGE_BIT_PAT_LARGE)
+#define _PAGE_SPECIAL	(_AC(1, L)<<_PAGE_BIT_SPECIAL)
+#define __HAVE_ARCH_PTE_SPECIAL
 
 #if defined(CONFIG_X86_64) || defined(CONFIG_X86_PAE)
 #define _PAGE_NX	(_AC(1, ULL) << _PAGE_BIT_NX)
@@ -149,7 +152,7 @@ static inline int pte_file(pte_t pte)		{
 static inline int pte_huge(pte_t pte)		{ return pte_val(pte) & _PAGE_PSE; }
 static inline int pte_global(pte_t pte) 	{ return pte_val(pte) & _PAGE_GLOBAL; }
 static inline int pte_exec(pte_t pte)		{ return !(pte_val(pte) & _PAGE_NX); }
-static inline int pte_special(pte_t pte)	{ return 0; }
+static inline int pte_special(pte_t pte)	{ return pte_val(pte) & _PAGE_SPECIAL; }
 
 static inline int pmd_large(pmd_t pte) {
 	return (pmd_val(pte) & (_PAGE_PSE|_PAGE_PRESENT)) ==
@@ -167,7 +170,7 @@ static inline pte_t pte_mkhuge(pte_t pte
 static inline pte_t pte_clrhuge(pte_t pte)	{ return __pte(pte_val(pte) & ~(pteval_t)_PAGE_PSE); }
 static inline pte_t pte_mkglobal(pte_t pte)	{ return __pte(pte_val(pte) | _PAGE_GLOBAL); }
 static inline pte_t pte_clrglobal(pte_t pte)	{ return __pte(pte_val(pte) & ~(pteval_t)_PAGE_GLOBAL); }
-static inline pte_t pte_mkspecial(pte_t pte)	{ return pte; }
+static inline pte_t pte_mkspecial(pte_t pte)	{ return __pte(pte_val(pte) | _PAGE_SPECIAL); }
 
 extern pteval_t __supported_pte_mask;
 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-03-28  2:55 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-28  2:54 [patch 0/2]: lockless get_user_pages patchset Nick Piggin
2008-03-28  2:55 ` Nick Piggin [this message]
2008-03-28  3:23   ` [patch 1/2]: x86: implement pte_special David Miller, Nick Piggin
2008-03-28  3:31     ` Nick Piggin
2008-03-28  3:44       ` David Miller, Nick Piggin
2008-03-28  4:04         ` Nick Piggin
2008-03-28  4:09           ` David Miller, Nick Piggin
2008-03-28  4:15             ` Nick Piggin
2008-03-28  4:16               ` David Miller, Nick Piggin
2008-03-28  4:19                 ` Nick Piggin
2008-03-28  4:17               ` Nick Piggin
2008-03-28  3:00 ` [patch 2/2]: introduce fast_gup Nick Piggin
2008-03-28 10:01   ` Jens Axboe
2008-04-17 15:03   ` Peter Zijlstra
2008-04-17 15:25     ` Linus Torvalds
2008-04-17 16:12       ` Peter Zijlstra
2008-04-17 16:18         ` Linus Torvalds
2008-04-17 16:35           ` Peter Zijlstra
2008-04-17 16:40             ` Linus Torvalds
2008-04-17 17:23               ` Peter Zijlstra
2008-04-17 18:28                 ` Linus Torvalds
2008-04-22  3:14                   ` Nick Piggin
2008-04-18  6:31                 ` Geert Uytterhoeven
2008-04-18 14:40                   ` Linus Torvalds
2008-04-18  9:58         ` Jeremy Fitzhardinge
2008-04-21 12:00       ` Avi Kivity
2008-04-21 12:30         ` Peter Zijlstra
2008-04-21 13:26           ` Avi Kivity
2008-04-21 14:35             ` Peter Zijlstra
2008-04-22  3:23               ` Nick Piggin
2008-04-22  7:19                 ` Avi Kivity
2008-04-22  8:07                 ` Ingo Molnar
2008-04-22  9:42   ` Peter Zijlstra
2008-04-22  9:46     ` Nick Piggin
2008-05-14 18:33       ` Dave Kleikamp
2008-05-15  1:13         ` Nick Piggin
  -- strict thread matches above, loose matches on Subject: below --
2008-05-21 11:59 [patch 1/2] x86: implement pte_special Nick Piggin
2008-05-25 14:48 Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080328025541.GB8083@wotan.suse.de \
    --to=npiggin@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@oracle.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=shaggy@austin.ibm.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).