Re: [patch 10/19] blackfin: Use kbuild.h instead of defining macros in asm-macros.c

Re: [patch 10/19] blackfin: Use kbuild.h instead of defining macros in asm-macros.c

[Mike Frysinger]

On Mon, Apr 14, 2008 at 6:18 PM, Christoph Lameter <clameter@sgi.com> wrote:
> Cc: Mike Frysinger <vapier.adi@gmail.com>
>  Signed-off-by: Christoph Lameter <clameter@sgi.com>

nifty, thanks ... should add Bryan Wu to the chain
-mike

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [patch 17/19] Use kbuild.h instead of defining macros in asm-offsets.c

[Martin Schwidefsky]

On Mon, 2008-04-14 at 15:18 -0700, Christoph Lameter wrote:
> s390 has a strange marker in DEFINE. Undefine the DEFINE from kbuild.h and define
> it the way s390 wants it to preserve things as they were.

That is a leftover from the very first version of the asm-offsets code.
All the DEFINEs in arch/s390/kernel/asm-offsets.c have an empty third
argument, we never needed it.

> May be good if the arch maintainer could go over this and check if this workaround
> is really necessary.

No, the workaround can go. We can use the default macro if the DEFINE
lines get adapted: "s/,);/\);/"

-- 
blue skies,
  Martin.

"Reality continues to ruin my life." - Calvin.


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [patch 11/19] frv: Use kbuild.h instead of defining macros in asm-offsets.c

[David Howells]

arch/frv/kernel/asm-offsets.c:10:26: error: linux/kbuild.h: No such file or directory

Is this something that's queued in the -mm tree?

David

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [patch 11/19] frv: Use kbuild.h instead of defining macros in asm-offsets.c

[Christoph Lameter]

On Tue, 15 Apr 2008, David Howells wrote:

> arch/frv/kernel/asm-offsets.c:10:26: error: linux/kbuild.h: No such file or directory
> 
> Is this something that's queued in the -mm tree?

It hopefully will be queued soon.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [patch 02/19] x86: Use kbuild.h

[Ingo Molnar]

* Christoph Lameter <clameter@sgi.com> wrote:

> Drop the macro definitions in asm-offsets_*.c and use kbuild.h

thanks Christoph, applied.

	Ingo

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [patch 02/19] x86: Use kbuild.h

[Ingo Molnar]

* Ingo Molnar <mingo@elte.hu> wrote:

> * Christoph Lameter <clameter@sgi.com> wrote:
> 
> > Drop the macro definitions in asm-offsets_*.c and use kbuild.h
> 
> thanks Christoph, applied.

the dependency i missed was the existence of include/linux/kbuild.h ;-) 
Anyway:

Acked-by: Ingo Molnar <mingo@elte.hu>

	Ingo

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [patch 02/19] x86: Use kbuild.h

[Christoph Lameter]

On Wed, 16 Apr 2008, Ingo Molnar wrote:

> 
> * Ingo Molnar <mingo@elte.hu> wrote:
> 
> > * Christoph Lameter <clameter@sgi.com> wrote:
> > 
> > > Drop the macro definitions in asm-offsets_*.c and use kbuild.h
> > 
> > thanks Christoph, applied.
> 
> the dependency i missed was the existence of include/linux/kbuild.h ;-) 
> Anyway:
> 
> Acked-by: Ingo Molnar <mingo@elte.hu>

Yes sorry this is dependent on other patches merged by Andrew. This is the 
classic case of arch changes that depend on core changes.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [patch 02/19] x86: Use kbuild.h

[Andrew Morton]

On Wed, 16 Apr 2008 10:44:55 -0700 (PDT)
Christoph Lameter <clameter@sgi.com> wrote:

> On Wed, 16 Apr 2008, Ingo Molnar wrote:
> 
> > 
> > * Ingo Molnar <mingo@elte.hu> wrote:
> > 
> > > * Christoph Lameter <clameter@sgi.com> wrote:
> > > 
> > > > Drop the macro definitions in asm-offsets_*.c and use kbuild.h
> > > 
> > > thanks Christoph, applied.
> > 
> > the dependency i missed was the existence of include/linux/kbuild.h ;-) 
> > Anyway:
> > 
> > Acked-by: Ingo Molnar <mingo@elte.hu>
> 
> Yes sorry this is dependent on other patches merged by Andrew. This is the 
> classic case of arch changes that depend on core changes.

Yeah, I tricked a few people that way yesterday ;)

For this series I cc'ed 30-odd people on the core patch
(add-kbuildh-that-contains-common-definitions-for-kbuild-users.patch) and
then cc'ed them individually on the dependent patch (eg,
sparc-use-kbuildh-instead-of-defining-macros-in-asm-offsetsc.patch).  So
hopefully it was somewhat obvious what was going on.

In the case of *-use-get-put_unaligned_-helpers.patch it was more obscure
because the core patch
(kernel-add-common-infrastructure-for-unaligned-access.patch) came in a lot
earlier so nobody got to see it.  That tricked 'em.

Perhaps I should put "depends on -mm's
kernel-add-common-infrastructure-for-unaligned-access.patch" in the
changelog.  Problem is that I'd never remember to take that out before
sending the patch onwards.

I guess I could add "this depends on a patch which is only in -mm" into
that email somehow.

hm.  Oh well, it doesn't happen very often.




Related:

I'm now sitting on things like:

kernel-add-common-infrastructure-for-unaligned-access.patch
...
input-use-get_unaligned_-helpers.patch


Strictly and formally, the merge process for these is

a) I send kernel-add-common-infrastructure-for-unaligned-access.patch to
Linus.

b) He merges it

c) I send input-use-get_unaligned_-helpers.patch to Dmitry

d) He merges it

e) He sends input-use-get_unaligned_-helpers.patch to Linus

f) Linus merges it.


This is a lot of fuss and there's a non-zero chance that we'll miss the
merge window.  So I like people to send along acked-by's for this sort of
thing so I can scoot them along to Linus straight away.


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>