From: Ingo Molnar <mingo@elte.hu>
To: Mel Gorman <mel@csn.ul.ie>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] Make defencive checks around PFN values registered for memory usage
Date: Wed, 16 Apr 2008 16:02:33 +0200 [thread overview]
Message-ID: <20080416140233.GC24383@elte.hu> (raw)
In-Reply-To: <20080416135218.1346.41125.sendpatchset@skynet.skynet.ie>
* Mel Gorman <mel@csn.ul.ie> wrote:
> + if (*start_pfn > max_sparsemem_pfn) {
> + mminit_debug_printk(MMINIT_VERIFY, "pfnvalidation",
> + "Start of range %lu -> %lu exceeds SPARSEMEM max %lu\n",
> + *start_pfn, *end_pfn, max_sparsemem_pfn);
small request: please emit a WARN_ON_ONCE() as well, so that
kerneloops.org (and automated test setups) picks it up.
> + mminit_debug_printk(MMINIT_VERIFY, "pfnvalidation",
> + "End of range %lu -> %lu exceeds SPARSEMEM max %lu\n",
> + *start_pfn, *end_pfn, max_sparsemem_pfn);
ditto - all errors should be fixed up and we should try to continue as
far as possible, but emitting a WARN_ON_ONCE() will be very useful in
making sure people notice the warning.
Ingo
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-04-16 14:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-16 13:50 [PATCH 0/4] [RFC] Verification and debugging of memory initialisation Mel Gorman
2008-04-16 13:51 ` [PATCH 1/4] Add a basic debugging framework for " Mel Gorman
2008-04-16 14:04 ` Ingo Molnar
2008-04-16 19:30 ` Mel Gorman
2008-04-16 13:51 ` [PATCH 2/4] Verify the page links and memory model Mel Gorman
2008-04-16 19:12 ` Christoph Lameter
2008-04-16 20:16 ` Mel Gorman
2008-04-16 13:51 ` [PATCH 3/4] Print out the zonelists on request for manual verification Mel Gorman
2008-04-16 13:52 ` [PATCH 4/4] Make defencive checks around PFN values registered for memory usage Mel Gorman
2008-04-16 14:02 ` Ingo Molnar [this message]
2008-04-16 14:00 ` [PATCH 0/4] [RFC] Verification and debugging of memory initialisation Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080416140233.GC24383@elte.hu \
--to=mingo@elte.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).