Re: 2.6.25-mm1: not looking good

[Paul Moore <paul.moore@hp.com>]

On Thursday 17 April 2008 9:35:38 pm Andrew Morton wrote:
> I dropped git-selinux and that crash seems to have gone away.  It
> took about five minutes before, but would presumably have happened
> earlier if I'd reduced the cache size.
>
> btw, wouldn't this
>
> --- a/security/selinux/netnode.c~a
> +++ a/security/selinux/netnode.c
> @@ -190,7 +190,7 @@ static int sel_netnode_insert(struct sel
>  	if (sel_netnode_hash[idx].size == SEL_NETNODE_HASH_BKT_LIMIT) {
>  		struct sel_netnode *tail;
>  		tail = list_entry(node->list.prev, struct sel_netnode, list);
> -		list_del_rcu(node->list.prev);
> +		list_del_rcu(&tail->list);
>  		call_rcu(&tail->rcu, sel_netnode_free);
>  	} else
>  		sel_netnode_hash[idx].size++;
> _
>
> be a bit clearer?  If it's correct - I didn't try too hard :)

Looks good to me, although before I fix this let me try and figure out 
why this code is causing the machine to puke all over itself.  
Priorities you know :)

-- 
paul moore
linux @ hp

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>