From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e1.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id m3OFt4LW014330 for ; Thu, 24 Apr 2008 11:55:04 -0400 Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m3OFt4E5225154 for ; Thu, 24 Apr 2008 11:55:04 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m3OFsrO8017221 for ; Thu, 24 Apr 2008 11:54:54 -0400 Date: Thu, 24 Apr 2008 08:54:41 -0700 From: Nishanth Aravamudan Subject: Re: [RFC][PATCH 4/5] Documentation: add node files to sysfs ABI Message-ID: <20080424155441.GA8451@us.ibm.com> References: <20080412094118.GA7708@wotan.suse.de> <20080413034136.GA22686@suse.de> <20080414210506.GA6350@us.ibm.com> <20080417231617.GA18815@us.ibm.com> <20080422051447.GI21993@wotan.suse.de> <20080422165602.GA29570@us.ibm.com> <20080423010259.GA17572@wotan.suse.de> <20080423183252.GA10548@us.ibm.com> <20080424071352.GB14543@wotan.suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080424071352.GB14543@wotan.suse.de> Sender: owner-linux-mm@kvack.org Return-Path: To: Nick Piggin Cc: Christoph Lameter , Greg KH , wli@holomorphy.com, agl@us.ibm.com, luick@cray.com, Lee.Schermerhorn@hp.com, linux-mm@kvack.org List-ID: On 24.04.2008 [09:13:52 +0200], Nick Piggin wrote: > On Wed, Apr 23, 2008 at 11:32:52AM -0700, Nishanth Aravamudan wrote: > > > > So, I think, we pretty much agree on how things should be: > > > > Direct translation of the current sysctl: > > > > /sys/kernel/hugepages/nr_hugepages > > nr_overcommit_hugepages > > > > Adding multiple pools: > > > > /sys/kernel/hugepages/nr_hugepages -> nr_hugepages_${default_size} > > nr_overcommit_hugepages -> nr_overcommit_hugepages_${default_size} > > nr_hugepages_${default_size} > > nr_overcommit_hugepages_${default_size} > > nr_hugepages_${other_size1} > > nr_overcommit_hugepages_${other_size2} > > > > Adding per-node control: > > > > /sys/kernel/hugepages/nr_hugepages -> nr_hugepages_${default_size} > > nr_overcommit_hugepages -> nr_overcommit_hugepages_${default_size} > > nr_hugepages_${default_size} > > nr_overcommit_hugepages_${default_size} > > nr_hugepages_${other_size1} > > nr_overcommit_hugepages_${other_size2} > > nodeX/nr_hugepages -> nr_hugepages_${default_size} > > nr_overcommit_hugepages -> nr_overcommit_hugepages_${default_size} > > nr_hugepages_${default_size} > > nr_overcommit_hugepages_${default_size} > > nr_hugepages_${other_size1} > > nr_overcommit_hugepages_${other_size2} > > > > How does that look? Does anyone have any problems with such an > > arrangement? > > Looks pretty good. I would personally lean toward subdirectories for > hstates. Pros are that it would be a little easier to navigate from > the shell, and maybe more regular to program for. That's probably true -- and extracting the pagesize to which things correspond should be simpler too. And perhaps that would allow for easier output of meminfo for the various hugepage sizes? > You could possibly have hugepages_default symlink as well to one of > the directories of your choice. This could be used by apps which do > not specify exactly what size they want... Yep, that would seem sensible...or perhaps even have nr_hugepages in the root directory (and other corresponding files directly symlink into the default_size directory?). > I don't know, just ideas. Thanks for the feedback! -Nish -- Nishanth Aravamudan IBM Linux Technology Center -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org