From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e3.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id m3ONwkkA028978 for ; Thu, 24 Apr 2008 19:58:46 -0400 Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m3ONwkjG248556 for ; Thu, 24 Apr 2008 19:58:46 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m3ONwZrR017294 for ; Thu, 24 Apr 2008 19:58:36 -0400 Date: Thu, 24 Apr 2008 16:58:29 -0700 From: Nishanth Aravamudan Subject: Re: [patch 02/18] hugetlb: factor out huge_new_page Message-ID: <20080424235829.GC4741@us.ibm.com> References: <20080423015302.745723000@nick.local0.net> <20080423015429.834926000@nick.local0.net> <20080424235431.GB4741@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080424235431.GB4741@us.ibm.com> Sender: owner-linux-mm@kvack.org Return-Path: To: npiggin@suse.de Cc: akpm@linux-foundation.org, linux-mm@kvack.org, andi@firstfloor.org, kniht@linux.vnet.ibm.com, abh@cray.com, wli@holomorphy.com List-ID: On 24.04.2008 [16:54:31 -0700], Nishanth Aravamudan wrote: > On 23.04.2008 [11:53:04 +1000], npiggin@suse.de wrote: > > Needed to avoid code duplication in follow up patches. > > > > This happens to fix a minor bug. When alloc_bootmem_node returns > > a fallback node on a different node than passed the old code > > would have put it into the free lists of the wrong node. > > Now it would end up in the freelist of the correct node. > > This is rather frustrating. The whole point of having the __GFP_THISNODE > flag is to indicate off-node allocations are *not* supported from the > caller... This was all worked on quite heavily a while back. Oh I see. This patch refers to a bug that only is introduced by patch 12/18...perhaps *that* patch should add the nid calculation in the helper, if it is truly needed. Thanks, Nish -- Nishanth Aravamudan IBM Linux Technology Center -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org