From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Sat, 26 Apr 2008 22:10:29 -0700 From: Greg KH Subject: Re: [RFC][PATCH] hugetlb: add information and interface in sysfs [Was Re: [RFC][PATCH 4/5] Documentation: add node files to sysfs ABI] Message-ID: <20080427051029.GA22858@suse.de> References: <20080413034136.GA22686@suse.de> <20080414210506.GA6350@us.ibm.com> <20080417231617.GA18815@us.ibm.com> <20080422051447.GI21993@wotan.suse.de> <20080422165602.GA29570@us.ibm.com> <20080423010259.GA17572@wotan.suse.de> <20080423183252.GA10548@us.ibm.com> <20080424071352.GB14543@wotan.suse.de> <20080427034942.GB12129@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080427034942.GB12129@us.ibm.com> Sender: owner-linux-mm@kvack.org Return-Path: To: Nishanth Aravamudan Cc: Nick Piggin , Christoph Lameter , wli@holomorphy.com, agl@us.ibm.com, luick@cray.com, Lee.Schermerhorn@hp.com, linux-mm@kvack.org List-ID: On Sat, Apr 26, 2008 at 08:49:42PM -0700, Nishanth Aravamudan wrote: > > [20:41:56]nacc@arkanoid:/sys/kernel/hugepages$ cat /sys/kernel/hugepages/hugepages-2MB/meminfo > HugePages_Total: 0 > HugePages_Free: 0 > HugePages_Rsvd: 0 > HugePages_Surp: 0 > Hugepagesize: 2048 kB > > Greg, do you see any obvious violations of sysfs rules here? Well, beyond > meminfo itself, I guess, but given our previous snapshot discussion, I left it > simple and the same, rather than split it up. Yeah, I don't like that file. Why not just have 5 files, one for each value? There isn't such a need for an immediate snapshot shere you can't just read all 5 values from 5 files? Also, why use a "units" here, just always use the lowest unit, and userspace can convert from kB to GB if needed. thanks, greg k-h -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org