From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e34.co.us.ibm.com (8.13.8/8.13.8) with ESMTP id m3UKfqn8003920 for ; Wed, 30 Apr 2008 16:41:52 -0400 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m3UKiYMS192572 for ; Wed, 30 Apr 2008 14:44:34 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m3UKiXpo026481 for ; Wed, 30 Apr 2008 14:44:34 -0600 Date: Wed, 30 Apr 2008 13:44:28 -0700 From: Nishanth Aravamudan Subject: Re: [patch 02/18] hugetlb: factor out huge_new_page Message-ID: <20080430204428.GC6903@us.ibm.com> References: <20080423015302.745723000@nick.local0.net> <20080423015429.834926000@nick.local0.net> <20080424235431.GB4741@us.ibm.com> <20080424235829.GC4741@us.ibm.com> <481183FC.9060408@firstfloor.org> <20080425165424.GA9680@us.ibm.com> <20080425192942.GB14623@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: Andi Kleen , npiggin@suse.de, akpm@linux-foundation.org, linux-mm@kvack.org, kniht@linux.vnet.ibm.com, abh@cray.com, wli@holomorphy.com List-ID: On 30.04.2008 [12:16:39 -0700], Christoph Lameter wrote: > On Fri, 25 Apr 2008, Nishanth Aravamudan wrote: > > > I think so -- I'm not entirely sure. Andi, can you elucidate? > > Finally had a look at the patch. This is fine because the GFP_THISNODE > option during the alloc will return a page on the indicated node or > none. Right... > page_to_nid must therefore return the node that was specified at alloc > time. Sure, my point was that we already have the nid in the caller (because we specify it along with GFP_THISNODE). So if we pass that nid down into this new function, we shoulnd't need to do the page_to_nid() call, right? Thanks, Nish -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org