From: Nick Piggin <npiggin@suse.de>
To: David Miller <davem@davemloft.net>
Cc: torvalds@linux-foundation.org, hugh@veritas.com,
linux-arch@vger.kernel.org, linux-mm@kvack.org,
paulmck@us.ibm.com
Subject: Re: [patch 2/2] fix SMP data race in pagetable setup vs walking
Date: Tue, 6 May 2008 11:56:13 +0200 [thread overview]
Message-ID: <20080506095613.GG10141@wotan.suse.de> (raw)
In-Reply-To: <20080506.000803.80742226.davem@davemloft.net>
On Tue, May 06, 2008 at 12:08:03AM -0700, David Miller wrote:
> From: Nick Piggin <npiggin@suse.de>
> Date: Mon, 5 May 2008 14:12:40 +0200
>
> > I only converted x86 and powerpc. I think comments in x86 are good because
> > that is more or less the reference implementation and is where many VM
> > developers would look to understand mm/ code. Commenting all page table
> > walking in all other architectures is kind of beyond my skill or patience,
> > and maintainers might consider this weird "alpha thingy" is below them ;)
> > But they are quite free to add smp_read_barrier_depends to their own code.
> >
> > Still would like more acks on this before it is applied.
>
> I've read this over a few times, I think it's OK:
>
> Acked-by: David S. Miller <davem@davemloft.net>
Thanks a lot for that (and the others who reviewed). Gives me more
confidence.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-05-06 9:56 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-05 11:20 [patch 1/2] read_barrier_depends fixlets Nick Piggin
2008-05-05 12:12 ` [patch 2/2] fix SMP data race in pagetable setup vs walking Nick Piggin
2008-05-05 14:35 ` Paul E. McKenney
2008-05-06 9:38 ` Nick Piggin
2008-05-06 13:32 ` Paul E. McKenney
2008-05-13 7:55 ` Nick Piggin
2008-05-13 13:26 ` Paul E. McKenney
2008-05-05 15:32 ` Linus Torvalds
2008-05-05 16:37 ` Hugh Dickins
2008-05-06 9:51 ` Nick Piggin
2008-05-06 14:53 ` Linus Torvalds
2008-05-06 19:11 ` Paul E. McKenney
2008-05-14 4:27 ` Nick Piggin
2008-05-13 8:01 ` Nick Piggin
2008-05-13 15:45 ` Linus Torvalds
2008-05-14 0:34 ` Nick Piggin
2008-05-14 0:55 ` Linus Torvalds
2008-05-14 1:18 ` Nick Piggin
2008-05-14 4:35 ` [patch 1/2] read_barrier_depends arch fixlets Nick Piggin
2008-05-14 4:37 ` [patch 2/2] fix SMP data race in pagetable setup vs walking Nick Piggin
2008-05-14 13:26 ` [patch 1/2] read_barrier_depends arch fixlets Paul E. McKenney
2008-05-05 16:57 ` [patch 2/2] fix SMP data race in pagetable setup vs walking Hugh Dickins
2008-05-06 9:52 ` Nick Piggin
2008-05-06 7:08 ` David Miller, Nick Piggin
2008-05-06 9:56 ` Nick Piggin [this message]
2008-05-05 14:27 ` [patch 1/2] read_barrier_depends fixlets Paul E. McKenney
2008-05-06 9:01 ` Nick Piggin
2008-05-06 14:06 ` Paul E. McKenney
2008-05-06 15:29 ` David Howells
2008-05-06 19:09 ` Paul E. McKenney
2008-05-13 8:05 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080506095613.GG10141@wotan.suse.de \
--to=npiggin@suse.de \
--cc=davem@davemloft.net \
--cc=hugh@veritas.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=paulmck@us.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).