From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e36.co.us.ibm.com (8.13.8/8.13.8) with ESMTP id m47NdlYL002070 for ; Wed, 7 May 2008 19:39:47 -0400 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m47NdkHX197218 for ; Wed, 7 May 2008 17:39:46 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m47Ndje2031524 for ; Wed, 7 May 2008 17:39:46 -0600 Date: Wed, 7 May 2008 16:39:44 -0700 From: Nishanth Aravamudan Subject: Re: [PATCH] x86: fix PAE pmd_bad bootup warning Message-ID: <20080507233944.GG23990@us.ibm.com> References: <20080506124946.GA2146@elte.hu> <20080506202201.GB12654@escobedo.amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org Return-Path: To: Hugh Dickins Cc: Hans Rosenfeld , Ingo Molnar , Jeff Chua , Thomas Gleixner , "H. Peter Anvin" , Gabriel C , Arjan van de Ven , linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: On 06.05.2008 [21:36:59 +0100], Hugh Dickins wrote: > On Tue, 6 May 2008, Hans Rosenfeld wrote: > > On Tue, May 06, 2008 at 08:49:23PM +0100, Hugh Dickins wrote: > > > So Hans' original hugepage leak remains unexplained and unfixed. > > > Hans, did you find that hugepage leak with a standard kernel, or were > > > you perhaps trying out some hugepage-using patch of your own, without > > > marking the vma VM_HUGETLB? Or were you expecting the hugetlbfs file > > > to truncate itself once all mmappers had gone? If the standard kernel > > > leaks hugepages, I'm surprised the hugetlb guys don't know about it. > > > > I used a standard kernel (well, not quite, I had made some changes to > > the /proc/pid/pagemap code, but nothing that would affect the hugepage > > stuff) and some simple test program that would just mmap a hugepage. > > > > I expected that any hugepage that a process had mmapped would > > automatically be returned to the system when the process exits. That was > > not the case, the process exited and the hugepage was lost (unless I > > changed the program to explicitly munmap the hugepage before exiting). > > Removing the hugetlbfs file containing the hugepage also didn't free the > > page. > > Hmm. That doesn't fit with my experience: I've not found an explicit > munmap makes any difference (I wouldn't expect it to), but removing > the file once all openers gone does free everything up. I guess I'm > overlooking something more experienced hugepagers will soon light > upon. Nothing strikes me immediately. What you described is what I expected. As Dave pointed out separately, are you able to unmount hugetlbfs at this point? Hans, can you send out a sample application's source? What kernel were you testing on? Thanks, Nish -- Nishanth Aravamudan IBM Linux Technology Center -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org