From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 13 May 2008 20:22:45 -0500 From: Jack Steiner Subject: Re: [patch 2/2] mm: remove nopfn Message-ID: <20080514012245.GA6109@sgi.com> References: <20080513074723.GB12869@wotan.suse.de> <20080513074829.GC12869@wotan.suse.de> <20080513154812.GA23256@sgi.com> <20080513162046.GA22407@sgi.com> <20080514004456.GB24516@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080514004456.GB24516@wotan.suse.de> Sender: owner-linux-mm@kvack.org Return-Path: To: Nick Piggin Cc: Robin Holt , Andrew Morton , Linux Memory Management List List-ID: On Wed, May 14, 2008 at 02:44:56AM +0200, Nick Piggin wrote: > On Tue, May 13, 2008 at 11:20:46AM -0500, Jack Steiner wrote: > > On Tue, May 13, 2008 at 10:48:12AM -0500, Jack Steiner wrote: > > > On Tue, May 13, 2008 at 09:48:29AM +0200, Nick Piggin wrote: > > > > There are no users of nopfn in the tree. Remove it. > > > > > > > > > > The SGI mspec driver use to use the nopfn callout. I see that this > > > was recently changed but the new code fails with: > > > > Wait.... Looks like I missed the patch that deleted the BUG_ON. That should > > fix the problem (or at least change it). > > > > Retesting..... > > Thanks Jack, that would be a great help. Sorry, I should have cc'ed you > on the first patch as well so that it would be more clear that you have to > remove the BUG_ON. > No problem. I retested with the _correct_ patches. AFAICT, everything works fine. Both mspec & GRU. Should have dug deeper thru the mail lists.... --- jack -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org