From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 27 May 2008 15:53:03 +0100 Subject: Re: [PATCH 2/3] slub: record page flag overlays explicitly Message-ID: <20080527145250.GA3407@shadowen.org> References: <1211560402.0@pinky> <20080526133755.4664.KOSAKI.MOTOHIRO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080526133755.4664.KOSAKI.MOTOHIRO@jp.fujitsu.com> From: apw@shadowen.org Sender: owner-linux-mm@kvack.org Return-Path: To: KOSAKI Motohiro Cc: linux-mm@kvack.org, Andrew Morton , Christoph Lameter , KAMEZAWA Hiroyuki , Rik van Riel , Jeremy Fitzhardinge , linux-kernel@vger.kernel.org List-ID: On Mon, May 26, 2008 at 01:40:44PM +0900, KOSAKI Motohiro wrote: > Hi > > This patch works well on my box. > but I have one question. > > > if (s->flags & DEBUG_DEFAULT_FLAGS) { > > - if (!SlabDebug(page)) > > - printk(KERN_ERR "SLUB %s: SlabDebug not set " > > + if (!PageSlubDebug(page)) > > + printk(KERN_ERR "SLUB %s: SlubDebug not set " > > "on slab 0x%p\n", s->name, page); > > } else { > > - if (SlabDebug(page)) > > - printk(KERN_ERR "SLUB %s: SlabDebug set on " > > + if (PageSlubDebug(page)) > > + printk(KERN_ERR "SLUB %s: SlubDebug set on " > > "slab 0x%p\n", s->name, page); > > } > > } > > Why if(SLABDEBUG) check is unnecessary? They were unconditional before as well. SlabDebug would always return 0 before the patch. The point being, to my reading, that if you asked for debug on the slab and debug was not compiled in you would still get told that it was not set; which it cannot without the support. -apw -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org