From: Andi Kleen <andi@firstfloor.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Miquel van Smoorenburg <mikevs@xs4all.net>,
Andi Kleen <andi@firstfloor.org>,
Glauber Costa <gcosta@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] 2.6.26-rc: x86: pci-dma.c: use __GFP_NO_OOM instead of __GFP_NORETRY
Date: Wed, 28 May 2008 14:54:01 +0200 [thread overview]
Message-ID: <20080528125401.GC20824@one.firstfloor.org> (raw)
In-Reply-To: <20080528014017.9b3d116f.akpm@linux-foundation.org>
> > - page = dma_alloc_pages(dev, gfp, get_order(size));
> > + /* Don't invoke OOM killer or retry in lower 16MB DMA zone */
> > + page = dma_alloc_pages(dev,
> > + (gfp & GFP_DMA) ? gfp | __GFP_NORETRY : gfp, get_order(size));
> > if (page == NULL)
> > return NULL;
>
> I guess that's more specifally solving that-which-we-wish-to-solve.
Then the allocator could still be stuck in ZONE_DMA32 on 64bit.
Also d_a_c() does one "speculative" allocation, as in an allocation
where it knows the zone is too large for the mask but it tries anyways
because it often works. In that case too much trying is also not good.
-Andi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-05-28 12:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-26 23:49 [PATCH] 2.6.26-rc: x86: pci-dma.c: use __GFP_NO_OOM instead of __GFP_NORETRY Miquel van Smoorenburg
2008-05-27 8:03 ` Ingo Molnar
2008-05-27 8:47 ` Andrew Morton
2008-05-27 9:35 ` Miquel van Smoorenburg
2008-05-28 2:47 ` Andi Kleen
2008-05-28 8:31 ` Miquel van Smoorenburg
2008-05-28 8:40 ` Andrew Morton
2008-05-28 12:54 ` Andi Kleen [this message]
2008-06-02 10:15 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080528125401.GC20824@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=gcosta@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mikevs@xs4all.net \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).