linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Nick Piggin <npiggin@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: agl@us.ibm.com, nacc@us.ibm.com,
	Linux Memory Management List <linux-mm@kvack.org>,
	kosaki.motohiro@jp.fujitsu.com
Subject: [patch] hugetlb: fix lockdep error
Date: Thu, 29 May 2008 04:29:19 +0200	[thread overview]
Message-ID: <20080529022919.GD3258@wotan.suse.de> (raw)
In-Reply-To: <20080528191657.ba5f283c.akpm@linux-foundation.org>

Hi Andrew,

Can you merge this up please? It is helpful in testing to avoid lockdep
tripping over. I have it at the start of the multiple hugepage size
patchset, but it doesn't strictly belong there...

--
hugetlb: fix lockdep error

Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Acked-by: Adam Litke <agl@us.ibm.com>
Acked-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Nick Piggin <npiggin@suse.de>
---
 mm/hugetlb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6/mm/hugetlb.c
===================================================================
--- linux-2.6.orig/mm/hugetlb.c
+++ linux-2.6/mm/hugetlb.c
@@ -785,7 +785,7 @@ int copy_hugetlb_page_range(struct mm_st
 			continue;
 
 		spin_lock(&dst->page_table_lock);
-		spin_lock(&src->page_table_lock);
+		spin_lock_nested(&src->page_table_lock, SINGLE_DEPTH_NESTING);
 		if (!huge_pte_none(huge_ptep_get(src_pte))) {
 			if (cow)
 				huge_ptep_set_wrprotect(src, addr, src_pte);

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

       reply	other threads:[~2008-05-29  2:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080529015956.GC3258@wotan.suse.de>
     [not found] ` <20080528191657.ba5f283c.akpm@linux-foundation.org>
2008-05-29  2:29   ` Nick Piggin [this message]
2008-05-29  2:38     ` [patch] hugetlb: fix lockdep error Andrew Morton
2008-05-29  3:07       ` Nick Piggin
2008-05-29  3:19         ` Andrew Morton
2008-05-29  3:26           ` Nick Piggin
2008-05-29  3:35             ` Andrew Morton
2008-05-29  3:48           ` Nish Aravamudan
2008-05-29  8:58             ` Nick Piggin
2008-05-29 12:35           ` Adam Litke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080529022919.GD3258@wotan.suse.de \
    --to=npiggin@suse.de \
    --cc=agl@us.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-mm@kvack.org \
    --cc=nacc@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).