Re: [patch 07/23] hugetlb: multi hstate sysctls

[Nishanth Aravamudan <nacc@us.ibm.com>]

On 26.05.2008 [00:23:24 +1000], npiggin@suse.de wrote:
> Expand the hugetlbfs sysctls to handle arrays for all hstates. This
> now allows the removal of global_hstate -- everything is now hstate
> aware.
> 
> - I didn't bother with hugetlb_shm_group and treat_as_movable,
> these are still single global.
> - Also improve error propagation for the sysctl handlers a bit
> 
> Signed-off-by: Andi Kleen <ak@suse.de>
> Signed-off-by: Nick Piggin <npiggin@suse.de>

<snip>

>  int hugetlb_treat_movable_handler(struct ctl_table *table, int write,
>  			struct file *file, void __user *buffer,
>  			size_t *length, loff_t *ppos)
>  {
> + 	table->maxlen = max_hstate * sizeof(int);

Are you sure this is correct? I was just testing my sysfs patch (and the
removal of the multi-valued proc files) and noticed that
/proc/sys/vm/hugepages_treat_as_movable was multi-valued (3 values,
corresponding to the three page sizes on this machine), and the last
value was garbage. And, in any case, this change seems to conflict with
the changelog?

Thanks,
Nish

-- 
Nishanth Aravamudan <nacc@us.ibm.com>
IBM Linux Technology Center

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>