Re: [patch 3/7] mm: speculative page references

Nick Piggin
2008-06-11T03:19:26Z

On Tue, Jun 10, 2008 at 12:08:27PM -0700, Christoph Lameter wrote:
> On Thu, 5 Jun 2008, npiggin@suse.de wrote:
>
> > + * do the right thing (see comments above).
> > + */
> > + return 0;
> > + }
> > +#endif
> > + VM_BUG_ON(PageCompound(page) && (struct page *)page_private(page) != page);
>
> This is easier written as:
>
> == VM_BUG_ON(PageTail(page)

Yeah that would be nicer.

> And its also slightly incorrect since page_private(page) is not pointing
> to the head page for PageHead(page).

I see. Thanks.