From: Ingo Molnar <mingo@elte.hu>
To: Dave Young <hidave.darkstar@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, hpa@zytor.com,
the arch/x86 maintainers <x86@kernel.org>
Subject: Re: [PATCH] kernel parameter vmalloc size fix
Date: Mon, 16 Jun 2008 10:01:31 +0200 [thread overview]
Message-ID: <20080616080131.GC25632@elte.hu> (raw)
In-Reply-To: <20080616042528.GA3003@darkstar.te-china.tietoenator.com>
* Dave Young <hidave.darkstar@gmail.com> wrote:
> booting kernel with vmalloc=[any size<=16m] will oops.
>
> It's due to the vm area hole.
>
> In include/asm-x86/pgtable_32.h:
> #define VMALLOC_OFFSET (8 * 1024 * 1024)
> #define VMALLOC_START (((unsigned long)high_memory + 2 * VMALLOC_OFFSET - 1) \
> & ~(VMALLOC_OFFSET - 1))
>
> BUG_ON in arch/x86/mm/init_32.c will be triggered:
> BUG_ON((unsigned long)high_memory > VMALLOC_START);
>
> Fixed by return -EINVAL for invalid parameter
hm. Why dont we instead add the size of the hole to the
__VMALLOC_RESERVE value instead? There's nothing inherently bad about
using vmalloc=16m. The VM area hole is really a kernel-internal
abstraction that should not be visible in the usage of the parameter.
Ingo
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-06-16 8:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-16 4:25 [PATCH] kernel parameter vmalloc size fix Dave Young
2008-06-16 8:01 ` Ingo Molnar [this message]
2008-06-16 8:08 ` Dave Young
2008-06-16 8:52 ` Dave Young
2008-06-16 15:44 ` H. Peter Anvin
2008-06-24 5:49 ` Dave Young
2008-06-26 12:14 ` Ingo Molnar
2008-06-27 1:55 ` Dave Young
2008-07-11 7:05 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080616080131.GC25632@elte.hu \
--to=mingo@elte.hu \
--cc=hidave.darkstar@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox