From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e6.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id m620R6HX029392 for ; Tue, 1 Jul 2008 20:27:06 -0400 Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.0) with ESMTP id m620OXBA200070 for ; Tue, 1 Jul 2008 20:24:34 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m620OXGa003299 for ; Tue, 1 Jul 2008 20:24:33 -0400 Date: Tue, 1 Jul 2008 17:24:31 -0700 From: Nishanth Aravamudan Subject: Re: [patch 05/21] hugetlb: new sysfs interface Message-ID: <20080702002431.GA24625@us.ibm.com> References: <20080604112939.789444496@amd.local0.net> <20080604113111.647714612@amd.local0.net> <20080608115941.746732a5.akpm@linux-foundation.org> <20080610030234.GE19404@wotan.suse.de> <20080612011149.GA21542@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080612011149.GA21542@us.ibm.com> Sender: owner-linux-mm@kvack.org Return-Path: To: Nick Piggin Cc: Andrew Morton , linux-mm@kvack.org, Greg KH List-ID: On 11.06.2008 [19:11:49 -0600], Nishanth Aravamudan wrote: > On 10.06.2008 [05:02:34 +0200], Nick Piggin wrote: > > On Sun, Jun 08, 2008 at 11:59:41AM -0700, Andrew Morton wrote: > > > On Wed, 04 Jun 2008 21:29:44 +1000 npiggin@suse.de wrote: > > > > > > > Provide new hugepages user APIs that are more suited to multiple hstates in > > > > sysfs. There is a new directory, /sys/kernel/hugepages. Underneath that > > > > directory there will be a directory per-supported hugepage size, e.g.: > > > > > > > > /sys/kernel/hugepages/hugepages-64kB > > > > /sys/kernel/hugepages/hugepages-16384kB > > > > /sys/kernel/hugepages/hugepages-16777216kB > > > > > > Maybe /sys/mm or /sys/vm would be a more appropriate place. > > > > I'm thinking all the random kernel subsystems under /sys/ should > > rather be moved to /sys/kernel/. Imagine how much crap will be > > under the root directory if every kernel subsystem goes there. What random subsystems do you see under /sys that are better off under /sys/kernel? Keep in mind, sysfs is an ABI, so moving things is tricky if it's been in a mainline release. > > The system is the kernel, afterall, the subsystems should be under > > there (arguably /sys/kernel/mm/hugepages/ would be better again, in > > fact yes Nish can we do that?). > > It should be pretty easy. Just need to allocate and add an appropriate > kobject like kernel_kobj somewhere in the main vm initialization path > and then change the parent in my patch to be that one rather than > kernel_kobj. So I'm ready to start doing this, but am curious if you think you'll want to move the other mm-related bits under /sys/kernel/mm too (e.g., /sys/kernel/slab)? If so, then we'll need to plan for it, as it's an ABI change. If not, then we might have mm stuff in different locations. Thanks, Nish -- Nishanth Aravamudan IBM Linux Technology Center -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org