Re: + mm-remove-find_max_pfn_with_active_regions.patch added to -mm tree

Yinghai Lu
2008-07-28T21:24:37Z

On Mon, Jul 28, 2008 at 1:40 PM, Mel Gorman <mel@csn.ul.ie> wrote:
> On (28/07/08 13:14), Yinghai Lu didst pronounce:
>> > <SNIP>
>> >
>> > I'm not seeing what different a rename of the parameter will do. Even if
>> > the parameter was renamed, it does not mean current trace information during
>> > memory initialisation needs to be outputted as KERN_INFO which is what this
>> > patch is doing. I am still failing to understand why you want this information
>> > to be generally available.
>>
>> how about KERN_DEBUG?
>>
>> please check
>>
>
> Still NAK due to the noise. Admittedly, I introduced the noise
> in the first place but it was complained about then as well. See
> http://lkml.org/lkml/2006/11/27/124 and later this
> http://lkml.org/lkml/2006/11/27/134 .
>
> At the risk of repeating myself, I am still failing to understand why you want
> this information to be generally available at any loglevel. My expectation is
> that the information is only of relevance when debugging memory initialisation
> problems in which case mminit_loglevel can be used.

ok.
how do think about using meminit_debug to replace minit_loglevel?

YH