Re: + mm-remove-find_max_pfn_with_active_regions.patch added to -mm tree

Mel Gorman
2008-07-28T21:16:16Z

On (28/07/08 13:55), Andrew Morton didst pronounce:
> On Mon, 28 Jul 2008 21:40:00 +0100
> Mel Gorman <mel@csn.ul.ie> wrote:
>
> > > how about KERN_DEBUG?
> > >
> > > please check
> > >
> >
> > Still NAK due to the noise.
>
> blah. I changed the patch to this:
>

Seems reasonable, thanks. I'll keep a closer eye on the next -mm release to
make sure the discontig mem boot tests are still ok.

Acked-by: Mel Gorman <mel@csn.ul.ie>

> --- a/include/linux/mm.h~mm-remove-find_max_pfn_with_active_regions
> +++ a/include/linux/mm.h
> @@ -1041,7 +1041,6 @@ extern unsigned long absent_pages_in_ran
> extern void get_pfn_range_for_nid(unsigned int nid,
> unsigned long *start_pfn, unsigned long *end_pfn);
> extern unsigned long find_min_pfn_with_active_regions(void);
> -extern unsigned long find_max_pfn_with_active_regions(void);
> extern void free_bootmem_with_active_regions(int nid,
> unsigned long max_low_pfn);
> typedef int (*work_fn_t)(unsigned long, unsigned long, void *);
> diff -puN mm/page_alloc.c~mm-remove-find_max_pfn_with_active_regions mm/page_alloc.c
> --- a/mm/page_alloc.c~mm-remove-find_max_pfn_with_active_regions
> +++ a/mm/page_alloc.c
> @@ -3753,23 +3753,6 @@ unsigned long __init find_min_pfn_with_a
> return find_min_pfn_for_node(MAX_NUMNODES);
> }
>
> -/**
> - * find_max_pfn_with_active_regions - Find the maximum PFN registered
> - *
> - * It returns the maximum PFN based on information provided via
> - * add_active_range().
> - */
> -unsigned long __init find_max_pfn_with_active_regions(void)
> -{
> - int i;
> - unsigned long max_pfn = 0;
> -
> - for (i = 0; i < nr_nodemap_entries; i++)
> - max_pfn = max(max_pfn, early_node_map[i].end_pfn);
> -
> - return max_pfn;
> -}
> -
> /*
> * early_calculate_totalpages()
> * Sum pages in active regions for movable zone.
> _
>
>
> Which is what it should always have been. Only do one thing per patch,
> please. The presence of the work "also" in the changelog is usually a
> big hint that it should be split up.