Re: [PATCH 4/7] unevictable lru: add event counts to list scan

KOSAKI Motohiro
2008-07-30T20:37:40Z

> mm/vmscan.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> Index: linux-2.6.27-rc1-mmotm-30jul/mm/vmscan.c
> ===================================================================
> --- linux-2.6.27-rc1-mmotm-30jul.orig/mm/vmscan.c 2008-07-30 13:26:46.000000000 -0400
> +++ linux-2.6.27-rc1-mmotm-30jul/mm/vmscan.c 2008-07-30 13:34:58.000000000 -0400
> @@ -2407,6 +2407,7 @@ retry:
> __dec_zone_state(zone, NR_UNEVICTABLE);
> list_move(&page->lru, &zone->lru[l].list);
> __inc_zone_state(zone, NR_INACTIVE_ANON + l);
> + __count_vm_event(UNEVICTABLE_PGRESCUED);
> } else {
> /*
> * rotate unevictable list
> @@ -2440,6 +2441,7 @@ void scan_mapping_unevictable_pages(stru
> while (next < end &&
> pagevec_lookup(&pvec, mapping, next, PAGEVEC_SIZE)) {
> int i;
> + int pg_scanned = 0;
>
> zone = NULL;
>
> @@ -2448,6 +2450,7 @@ void scan_mapping_unevictable_pages(stru
> pgoff_t page_index = page->index;
> struct zone *pagezone = page_zone(page);
>
> + pg_scanned++;
> if (page_index > next)
> next = page_index;
> next++;
> @@ -2465,6 +2468,8 @@ void scan_mapping_unevictable_pages(stru
> if (zone)
> spin_unlock_irq(&zone->lru_lock);
> pagevec_release(&pvec);
> +
> + count_vm_events(UNEVICTABLE_PGSCANNED, pg_scanned);

yup, ok.

Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>