Re: [PATCH] x86_64: Implement personality ADDR_LIMIT_32BIT

Ingo Molnar
2008-10-03T08:02:44Z

* Kirill A. Shutemov <kirill@shutemov.name> wrote:

> - /* for MAP_32BIT mappings we force the legact mmap base */
> - if (!test_thread_flag(TIF_IA32) && (flags & MAP_32BIT))
> + /* for MAP_32BIT mappings and ADDR_LIMIT_32BIT personality we force the
> + * legact mmap base
> + */

please use the customary multi-line comment style:

/*
* Comment .....
* ...... goes here:
*/

and you might use the opportunity to fix the s/legact/legacy typo as
well.

but more generally, we already have ADDR_LIMIT_3GB support on x86. Why
should support for ADDR_LIMIT_32BIT be added?

Ingo