Re: [PATCH, RFC] shmat: introduce flag SHM_MAP_HINT

Alan Cox
2008-10-07T12:31:32Z

> > Honestly, I don't like that qemu specific feature insert into shmem core.
> > At least, this patch is too few comments.
> > Therefore, an develpper can't understand why SHM_MAP_HINT exist.
> >
> > I think this patch description is too short and too poor.
> > I don't like increasing mysterious interface.
>
> Sorry for it. I'll fix it in next patch version.

I also don't see the point of this interface. We have POSIX shared memory
objects in Linux which are much cleaner and neater. They support mmap()
and mmap supports address hints.

There seems to be no reason at all to add further hacks to the historical
ugly SYS5 interface.

Alan