Re: [PATCH] x86_64: Implement personality ADDR_LIMIT_32BIT

Kirill A. Shutemov
2008-10-06T10:11:16Z

[-- Attachment #1: Type: text/plain, Size: 956 bytes --]

On Mon, Oct 06, 2008 at 11:56:28AM +0200, Andi Kleen wrote:
> > > And personality() is not thread local/safe, so it's not a particularly
> > > good interface to use later.
> >
> > qemu can call personality() before any threads will be created.
>
> It still makes it unsuitable for a lot of other applications.
> e.g. a JVM using 32bit pointers couldn't use it because it would
> affect native C threads running in the same process.
>
> >
> > > Per system call switches are preferable
> > > and more flexible.
> >
> > Per syscall switches are cool, but I don't see any advantage from it for
> > qemu.
>
> Linux interfaces are not supposed to be "interfaces for qemu" but generally
> applicable interfaces.

I know. What about adding both personality() and flag for shmat()? I can
prepare patch that implement flag for shmat().

--
Regards, Kirill A. Shutemov
+ Belarus, Minsk
+ ALT Linux Team, http://www.altlinux.com/

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]