Re: [PATCH, RFC] shmat: introduce flag SHM_MAP_HINT

KOSAKI Motohiro
2008-10-07T11:26:05Z

> > Honestly, I don't like that qemu specific feature insert into shmem core.
>
> I wouldn't say it's a qemu specific interface. While qemu would
> be the first user I would expect more in the future. It's a pretty
> obvious extension. In fact it nearly should be default, if the
> risk of breaking old applications wasn't too high.

hm, ok, i understand your intension.
however, I think following code isn't self describing.

addr = shmat(shmid, addr, SHM_MAP_HINT);

because HINT is too generic word.
I think we should find better word.

SHM_MAP_NO_FIXED ?

In addision, I still think current patch has too poor description and too
few comments.