Re: [PATCH, RFC] shmat: introduce flag SHM_MAP_HINT

Andi Kleen
2008-10-07T11:50:52Z

On Tue, Oct 07, 2008 at 02:30:51PM +0300, Kirill A. Shutemov wrote:
> On Tue, Oct 07, 2008 at 08:26:03PM +0900, KOSAKI Motohiro wrote:
> > > > Honestly, I don't like that qemu specific feature insert into shmem core.
> > >
> > > I wouldn't say it's a qemu specific interface. While qemu would
> > > be the first user I would expect more in the future. It's a pretty
> > > obvious extension. In fact it nearly should be default, if the
> > > risk of breaking old applications wasn't too high.
> >
> > hm, ok, i understand your intension.
> > however, I think following code isn't self describing.
> >
> > addr = shmat(shmid, addr, SHM_MAP_HINT);
> >
> > because HINT is too generic word.
> > I think we should find better word.
> >
> > SHM_MAP_NO_FIXED ?
>
> I like it.
> Andi?

SHM_MAP_NOT_FIXED perhaps.

I personally would call it SHM_MAP_SEARCH_HINT

But to be honest I have no strong opinion on the naming. Perhaps others have.

-Andi
--
ak@linux.intel.com