Re: [RFC][PATCH 10/11] memcg: swap cgroup

KAMEZAWA Hiroyuki
2008-10-28T00:10:01Z

On Mon, 27 Oct 2008 16:02:16 +0900
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> wrote:

> > + memset(array, 0, array_size);
> > + ctrl = &swap_cgroup_ctrl[type];
> > + mutex_lock(&swap_cgroup_mutex);
> > + ctrl->length = length;
> > + ctrl->map = array;
> > + if (swap_cgroup_prepare(type)) {
> > + /* memory shortage */
> > + ctrl->map = NULL;
> > + ctrl->length = 0;
> > + vfree(array);
> > + mutex_unlock(&swap_cgroup_mutex);
> > + goto nomem;
> > + }
> > + mutex_unlock(&swap_cgroup_mutex);
> > +
> > + printk(KERN_INFO
> > + "swap_cgroup: uses %ldbytes vmalloc and %ld bytes buffres\n",
> just a minor nitpick, s/ldbytes/ld bytes.
>
yes. thank you for review.

-Kame

>
> Thanks,
> Daisuke Nishimura.