Re: [patch 0/9] vmalloc fixes and improvements

Nick Piggin
2008-11-09T02:15:50Z

On Sat, Nov 08, 2008 at 04:00:48PM +0100, Johannes Weiner wrote:
> On Sat, Nov 08, 2008 at 06:41:44AM +0100, Nick Piggin wrote:
> > On Fri, Nov 07, 2008 at 09:13:38PM -0800, Linus Torvalds wrote:
> > >
> > >
> > > On Sat, 8 Nov 2008, npiggin@suse.de wrote:
> > > >
> > > > The following patches are a set of fixes and improvements for the vmap
> > > > layer.
> > >
> > > They seem seriously buggered.
> > >
> > > Patches that seem to be authorted by others (judging by sign-off) have no
> > > such attribution. And because you apparently use some sh*t-for-emailer,
> > > the patches that _are_ yours are missing your name, because it just says
> > >
> > > From: npiggin@suse.de
> > >
> > > without any "Nick Piggin" there.
> > >
> > > I'd suggest fixing your emailer scripts regardless, but a "From: " at the
> > > top of the body would fix both the attribution to others, and give you a
> > > name too.
> >
> > I thought when there is no From in the body, then it defaults to the first
> > Signed-off-by:. At least Andrew's scripts IIRC have got that right? (unless
> > it is Andrew fixing it manually).
>
> I thought just the last From: line in the raw email text, including
> both headers and body. So it defaults to the header which your mua
> sets automatically or you override it with an extra From:-line in the
> body to attribute authorship to somebody else.
>
> But you apperently just need to set a --from switch in .quiltrc's
> QUILT_MAIL_ARGS.

OK, will do that. Thanks.