From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 11 Nov 2008 13:01:49 -0800 From: Andrew Morton Subject: Re: [PATCH 1/4] rmap: add page_wrprotect() function, Message-Id: <20081111130149.4ee2969c.akpm@linux-foundation.org> In-Reply-To: <20081111203806.GE10818@random.random> References: <1226409701-14831-1-git-send-email-ieidus@redhat.com> <1226409701-14831-2-git-send-email-ieidus@redhat.com> <20081111113948.f38b9e95.akpm@linux-foundation.org> <20081111203806.GE10818@random.random> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Andrea Arcangeli Cc: ieidus@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, chrisw@redhat.com, avi@redhat.com, izike@qumranet.com List-ID: On Tue, 11 Nov 2008 21:38:06 +0100 Andrea Arcangeli wrote: > > > + * set all the ptes pointed to a page as read only, > > > + * odirect_sync is set to 0 in case we cannot protect against race with odirect > > > + * return the number of ptes that were set as read only > > > + * (ptes that were read only before this function was called are couned as well) > > > + */ > > > > But it isn't. > > What isn't? This code comment had the kerneldoc marker ("/**") but it isn't a kerneldoc comment. > > I don't understand this odirect_sync thing. What race? Please expand > > this comment to make the function of odirect_sync more understandable. > > I should have answered this one with the above 3 links. OK, well can we please update the code so these things are clearer. (It's a permanent problem I have. I ask "what is this", but I really mean "the code should be changed so that readers will know what this is") > > What do you think about making all this new code dependent upon some > > CONFIG_ switch which CONFIG_KVM can select? > > I like that too. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org